Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Jul 2016 19:28:24 +0000 (UTC)
From:      Navdeep Parhar <np@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r303199 - head/usr.sbin/ctld
Message-ID:  <201607221928.u6MJSOSP037030@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: np
Date: Fri Jul 22 19:28:23 2016
New Revision: 303199
URL: https://svnweb.freebsd.org/changeset/base/303199

Log:
  ctld(8): Fix MaxBurstLength negotiation.
  
  The target must reply with the selected value of MaxBurstSize instead of
  just echoing back the initiator's offered value.
  
  Reviewed by:	mav@
  Sponsored by:	Chelsio Communications
  Differential Revision:	https://reviews.freebsd.org/D7278

Modified:
  head/usr.sbin/ctld/login.c

Modified: head/usr.sbin/ctld/login.c
==============================================================================
--- head/usr.sbin/ctld/login.c	Fri Jul 22 17:36:40 2016	(r303198)
+++ head/usr.sbin/ctld/login.c	Fri Jul 22 19:28:23 2016	(r303199)
@@ -569,7 +569,7 @@ login_negotiate_key(struct pdu *request,
 			tmp = MAX_BURST_LENGTH;
 		}
 		conn->conn_max_burst_length = tmp;
-		keys_add(response_keys, name, value);
+		keys_add_int(response_keys, name, tmp);
 	} else if (strcmp(name, "FirstBurstLength") == 0) {
 		tmp = strtoul(value, NULL, 10);
 		if (tmp <= 0) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607221928.u6MJSOSP037030>