Date: Thu, 7 Jul 2005 18:47:21 GMT From: Andrew Bernard <andrewb@cs.cmu.edu> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/83108: xconq tcl/tk interface doesn't work Message-ID: <200507071847.j67IlLkC029973@www.freebsd.org> Resent-Message-ID: <200507071850.j67IoGf3021382@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 83108
>Category: ports
>Synopsis: xconq tcl/tk interface doesn't work
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jul 07 18:50:16 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Andrew Bernard
>Release: 5.3-RELEASE
>Organization:
>Environment:
FreeBSD dedalus.neglectgravity.com 5.3-RELEASE FreeBSD 5.3-RELEASE #0: Sun Feb 13 21:04:15 EST 2005 andrew@dedalus.neglectgravity:/usr/src/sys/i386/compile/DEDALUS i386
>Description:
The tcl/tk interface in the port games/xconq doesn't work.
For example, try to start a new Introductory game:
Error: ambiguous option "-pad": must be -column, ...
This could be a library version incompatibility.
>How-To-Repeat:
Run xconq
Click "New Game"
Select "Introductory Game"
Click "New Game"
>Fix:
Here's a patch that replaces uses of "-pad N" with "-padx N -pady N".
This seems to fix the problem.
diff -Naur tcltk.orig/tkconq.tcl tcltk/tkconq.tcl
--- tcltk.orig/tkconq.tcl Thu Jul 7 14:35:10 2005
+++ tcltk/tkconq.tcl Thu Jul 7 14:35:47 2005
@@ -472,7 +472,7 @@
-state $variantstate($col2) -variable variantvalue($col2) \
-command [ list set_variant_value_cmd $col2 ]
grid .newgame.top.checks.v$col1 .newgame.top.checks.v$col2 \
- -sticky w -pad 5
+ -sticky w -padx 5 -pady 5
}
for { set v 0 } { $v < 16 } { incr v } {
if { "$variantstate($v)" == "active" } {
@@ -785,37 +785,37 @@
-command { adjust_advantage_cmd 1 }
button .newgame.top.plbuttons.aminus -text "A-" -state disabled \
-command { adjust_advantage_cmd -1 }
- grid .newgame.top.plbuttons.aplus .newgame.top.plbuttons.aminus -sticky ew -pad 2
+ grid .newgame.top.plbuttons.aplus .newgame.top.plbuttons.aminus -sticky ew -padx 2 -pady 2
button .newgame.top.plbuttons.add -text "Add" \
-command { add_player_cmd } -width 8
- grid .newgame.top.plbuttons.add -columnspan 2 -sticky ew -pad 2
+ grid .newgame.top.plbuttons.add -columnspan 2 -sticky ew -padx 2 -pady 2
button .newgame.top.plbuttons.remove -text "Remove" -width 8
- grid .newgame.top.plbuttons.remove -columnspan 2 -sticky ew -pad 2
+ grid .newgame.top.plbuttons.remove -columnspan 2 -sticky ew -padx 2 -pady 2
menubutton .newgame.top.plbuttons.sidelib -text "Side Name" \
-menu .newgame.top.plbuttons.sidelib.menu \
-borderwidth 2 -relief raised -width 8
menu .newgame.top.plbuttons.sidelib.menu -tearoff 0
- grid .newgame.top.plbuttons.sidelib -columnspan 2 -sticky ew -pad 2
+ grid .newgame.top.plbuttons.sidelib -columnspan 2 -sticky ew -padx 2 -pady 2
button .newgame.top.plbuttons.rename -text "Random" \
-command { rename_side_for_player_cmd -1 } -width 8
- grid .newgame.top.plbuttons.rename -columnspan 2 -sticky ew -pad 2
+ grid .newgame.top.plbuttons.rename -columnspan 2 -sticky ew -padx 2 -pady 2
button .newgame.top.plbuttons.computer -text "Computer" \
-command { cycle_ai_cmd } -width 8
- grid .newgame.top.plbuttons.computer -columnspan 2 -sticky ew -pad 2
+ grid .newgame.top.plbuttons.computer -columnspan 2 -sticky ew -padx 2 -pady 2
button .newgame.top.plbuttons.exchange -text "Exchange" \
-command { exchange_players_cmd } -width 8
- grid .newgame.top.plbuttons.exchange -columnspan 2 -sticky ew -pad 2
+ grid .newgame.top.plbuttons.exchange -columnspan 2 -sticky ew -padx 2 -pady 2
label .newgame.top.plbuttons.indeplabel -text "Indep Units"
- grid .newgame.top.plbuttons.indeplabel -columnspan 2 -sticky ew -pad 2
+ grid .newgame.top.plbuttons.indeplabel -columnspan 2 -sticky ew -padx 2 -pady 2
button .newgame.top.plbuttons.indepside -text "Add AI" \
-command { set_indepside toggle } -width 6
- grid .newgame.top.plbuttons.indepside -columnspan 2 -pad 2
+ grid .newgame.top.plbuttons.indepside -columnspan 2 -padx 2 -pady 2
button .newgame.top.plbuttons.indepconfig -text "Config" \
-command { popup_indepside_config } -width 6
- grid .newgame.top.plbuttons.indepconfig -columnspan 2 -pad 2
+ grid .newgame.top.plbuttons.indepconfig -columnspan 2 -padx 2 -pady 2
# Add names to the side library menu, disabling already-used names.
set numsidelib [ side_lib_size ]
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507071847.j67IlLkC029973>