From owner-cvs-src@FreeBSD.ORG Tue Jun 28 19:21:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9632616A421; Tue, 28 Jun 2005 19:21:12 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 064B043D1D; Tue, 28 Jun 2005 19:21:11 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.231] (Not Verified[65.202.103.25]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Tue, 28 Jun 2005 15:34:55 -0400 From: John Baldwin To: =?iso-8859-1?q?S=F8ren_Schmidt?= Date: Tue, 28 Jun 2005 15:20:59 -0400 User-Agent: KMail/1.8 References: <200506280906.j5S96qIi053675@repoman.freebsd.org> <200506281310.50238.jhb@FreeBSD.org> <8EFCED13-E340-4C7D-A13B-3A5B01C4241E@FreeBSD.org> In-Reply-To: <8EFCED13-E340-4C7D-A13B-3A5B01C4241E@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200506281521.00598.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2005 19:21:12 -0000 On Tuesday 28 June 2005 02:24 pm, S=F8ren Schmidt wrote: > On 28/06/2005, at 19:10, John Baldwin wrote: > > On Tuesday 28 June 2005 11:30 am, S=F8ren Schmidt wrote: > >> On 28/06/2005, at 15:51, John Baldwin wrote: > >>> On Tuesday 28 June 2005 05:06 am, SXren Schmidt wrote: > >>>> sos 2005-06-28 09:06:52 UTC > >>>> > >>>> FreeBSD src repository > >>>> > >>>> Modified files: > >>>> sys/dev/ata ata-queue.c > >>>> Log: > >>>> Zero donecount on auto request sense. > >>>> > >>>> PR: 81450 > >>>> Approved by: re@ (scottl) > >>> > >>> Are you going to commit this to 5.x now as well? FWIW, the patch > >>> in question > >>> was straight from the bug report as well. > >> > >> Well, I thought that the plan was to have 6.0 be the solution to 5.x > >> problems ;) > >> > >> Anyhow if/when I'll commit anything to 5.x, it will be the ATA driver > >> from 6.0/current. > >> The problem being that the ABI for atacontrol etc has changed so it > >> kindof breaks the charter of -stable IMHO. > >> Other than that I have the bits sitting here on my lone -stable box > >> just waiting for a push on the big red commit key :) > >> . > >> - S=F8ren > > > > Well is it ok if I merge just this change to 5.x then? > > As I've stated earlier I don't support what's been put into 5.x to > "fix" bugs. > ATA mkIII is the fix for the 5.x problems/bugs from this end, so you > can do exactly what you want on the ATA code in 5.x as I don't really > care :) I'll be sure to remember that helpful attitude the next time you have an is= sue=20 with one of your production machines that I could help with. Also, given=20 that you committed the exact patch from the PR to HEAD and then claimed whe= n=20 you closed the PR prematurely that it was "solved (differently) in -current= "=20 that was very rude to the submitter who took time to find a bug in *your*=20 code and submit a working patch to fix it. I've also offered numerous times to do the actual commit of the fix to 5.x = if=20 you would give it a quick glance over but you always responded to both me a= nd=20 the submitter by saying that the bug was already fixed in ata mkIII and=20 wouldn't comment on the validity of the patch other than to say that the bu= g=20 was fixed differently in a different file in current. Given that you just= =20 now committed the exact patch to HEAD, it would seem that, in fact, ata mkI= II=20 did _not_ contain the correct fix as you had previously stated, and I guess= =20 the fact that you committed it to HEAD finally gives me some actual feedbac= k=20 on my requests for you to give it a quick review so the fix could be put in= =20 5.x (since I was under the impression from your earlier e-mails that this=20 issue was present on 5.x only). =2D-=20 John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =3D http://www.FreeBSD.org