Date: Fri, 13 Jan 2006 21:02:13 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Xin LI <delphij@FreeBSD.org> Cc: arch@FreeBSD.org, re@FreeBSD.org Subject: Re: review: patch to restore VLAN kernel API in RELENG_6 Message-ID: <20060113180213.GH83922@cell.sick.ru> In-Reply-To: <20060113175212.GA4170@hub.freebsd.org> References: <20060113170552.GF83922@FreeBSD.org> <20060113171759.GA1255@hub.freebsd.org> <20060113172049.GG83922@cell.sick.ru> <20060113175212.GA4170@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 13, 2006 at 05:52:12PM +0000, Xin LI wrote:
X> On Fri, Jan 13, 2006 at 08:20:49PM +0300, Gleb Smirnoff wrote:
X> > On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
X> > X> > +++ sys/dev/bge/if_bge.c 13 Jan 2006 17:04:31 -0000
X> > X> > @@ -2862,7 +2862,7 @@
X> > X> > * attach that information to the packet.
X> > X> > */
X> > X> > if (have_tag) {
X> > X> > - VLAN_INPUT_TAG(ifp, m, vlan_tag);
X> > X> > + VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
X> > X>
X> > X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
X> > X>
X> > X> Just my $0.02, though :-)
X> >
X> > I really don't care. :)
X>
X> Heh, my point was to make it possible to use the same name in
X> both drivers on RELENG_6 and 7.0, without having to call future
X> macros "foo_NEW_NG" or so =-) Not really sure whether it is
X> conform to our tradition naming, though...
The correct macro takes 3 arguments, and the old one took 4. So
we can't make a code compilable with correct macro on both systems
without breaking API - using same macro.
--
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060113180213.GH83922>