Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Mar 2017 03:33:54 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Michael Gmelin <grembo@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r435110 - in head/textproc: . kiss-templates
Message-ID:  <20170301033354.GA74787@FreeBSD.org>
In-Reply-To: <201702282328.v1SNStnU098880@repo.freebsd.org>
References:  <201702282328.v1SNStnU098880@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 28, 2017 at 11:28:55PM +0000, Michael Gmelin wrote:
> New Revision: 435110
> URL: https://svnweb.freebsd.org/changeset/ports/435110
> 
> Log:
>   New port: textproc/kiss-templates
> 
> Added: head/textproc/kiss-templates/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/textproc/kiss-templates/Makefile	Tue Feb 28 23:28:55 2017	(r435110)
> @@ -0,0 +1,32 @@
> +# Created by: Andreas Sommer <andreas.sommer87@googlemail.com>
> +# $FreeBSD$
> +
> +PORTNAME=		kiss-templates
> +PORTVERSION=		0.18
> +CATEGORIES=		textproc
> [... and below ...]

Indentation is broken in the Makefile (off by one tab).  Can you please fix
it?  Also, port description should be more than a copy of COMMENT, allow me
to quote section 3.2.1 of PHB:

 "A well-written pkg-descr describes the port completely enough that users
  would not have to consult the documentation or visit the website to
  understand what the software does, how it can be useful, or what
  particularly nice features it has."

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170301033354.GA74787>