Date: Sun, 28 Feb 2021 16:36:31 +0000 (UTC) From: Alexey Dokuchaev <danfe@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r566774 - head/deskutils/gworkspace Message-ID: <202102281636.11SGaVUq039466@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: danfe Date: Sun Feb 28 16:36:31 2021 New Revision: 566774 URL: https://svnweb.freebsd.org/changeset/ports/566774 Log: 1) The -fno-common fix attempt in r561452 was actually wrong: it marked the declaration of the variable ``serverConnection'' as extern, but there is no corresponding definition of the variable, so it remained an unresolved symbol (that didn't result in a build failure, because GNUstep applications are linked as a shared object) 2) GC leftovers from r132311: unreferenced ADDITIONAL_LDFLAGS and bogus USES+=ghostscript (PDF viewer requires PDFKit framework which is not available from the Ports Collection) Reported by: naddy (1) Obtained from: Debian Modified: head/deskutils/gworkspace/Makefile Modified: head/deskutils/gworkspace/Makefile ============================================================================== --- head/deskutils/gworkspace/Makefile Sun Feb 28 15:46:12 2021 (r566773) +++ head/deskutils/gworkspace/Makefile Sun Feb 28 16:36:31 2021 (r566774) @@ -2,7 +2,7 @@ PORTNAME= gworkspace PORTVERSION= 0.9.4 -PORTREVISION= 4 +PORTREVISION= 5 CATEGORIES= deskutils gnustep #MASTER_SITES= http://www.gnustep.it/enrico/gworkspace/ MASTER_SITES= GNUSTEP/usr-apps @@ -17,19 +17,6 @@ USE_GNUSTEP= back build USE_LDCONFIG= ${GNUSTEP_SYSTEM_LIBRARIES} GNU_CONFIGURE= yes -ADDITIONAL_LDFLAGS+= -L${WRKSRC}/FSNode/FSNode.framework/Versions/A - -.if defined(WITHOUT_GHOSTSCRIPT) -PLIST_SUB+= PDFVIEW="@comment " -.else -PLIST_SUB+= PDFVIEW="" -USES+= ghostscript -.endif - -post-patch: -# Fix the build with -fno-common (for Clang 11 and GCC 10) - @${REINPLACE_CMD} -e '/serverConnection/s,^,extern ,' \ - ${WRKSRC}/Inspector/ContentViewers/ImageViewer/Resizer.h pre-configure: ${RM} -r ${WRKSRC}/GWMetadata
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102281636.11SGaVUq039466>