Date: Thu, 28 Mar 2019 12:24:15 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: Cy Schubert <Cy.Schubert@cschubert.com>, Ed Maste <emaste@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r345638 - head/sys/sys Message-ID: <201903281924.x2SJOFiJ042178@slippy.cwsent.com> In-Reply-To: Message from Oliver Pinter <oliver.pinter@hardenedbsd.org> of "Thu, 28 Mar 2019 19:14:33 %2B0100." <CAPQ4ffvLWKQSkPNr9zGBFL4JObabqt9wLV%2BkqMa9D3r1b-os5A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <CAPQ4ffvLWKQSkPNr9zGBFL4JObabqt9wLV+kqMa9D3r1b-os5A@mail.gma il.com> , Oliver Pinter writes: > --000000000000bdde9105852b868a > Content-Type: text/plain; charset="UTF-8" > > On Thursday, March 28, 2019, Cy Schubert <Cy.Schubert@cschubert.com> wrote: > > > In message <201903281056.x2SAuR5E070924@repo.freebsd.org>, Ed Maste > > writes: > > > Author: emaste > > > Date: Thu Mar 28 10:56:27 2019 > > > New Revision: 345638 > > > URL: https://svnweb.freebsd.org/changeset/base/345638 > > > > > > Log: > > > Revert change accidentally committed along with r345625 > > > > > > Reported by: Oliver Pinter <oliver.pinter@hardenedbsd.org> > > > > > > Modified: > > > head/sys/sys/elf_common.h > > > > > > Modified: head/sys/sys/elf_common.h > > > ============================================================ > > ================= > > > = > > > --- head/sys/sys/elf_common.h Thu Mar 28 09:51:37 2019 (r345637) > > > +++ head/sys/sys/elf_common.h Thu Mar 28 10:56:27 2019 (r345638) > > > @@ -763,8 +763,7 @@ typedef struct { > > > #define NT_FREEBSD_FEATURE_CTL 4 > > > > > > /* NT_FREEBSD_FEATURE_CTL desc[0] bits */ > > > -#define NT_FREEBSD_FCTL_ASLR_DISABLE 0x00000001 > > > -#define NT_FREEBSD_FCTL_IMPLIED_MAX_PROT 0x00000002 > > > +#define NT_FREEBSD_FCTL_ASLR_DISABLE 0x00000001 > > > > --- readelf.o --- > > /opt/src/svn-current/contrib/elftoolchain/readelf/readelf.c:3493:4: > > error: use of undeclared identifier 'NT_FREEBSD_FCTL_IMPLIED_MAX_PROT' > > { NT_FREEBSD_FCTL_IMPLIED_MAX_PROT, "IMPLIED_MAX_PROT" }, > > ^ > > 1 error generated. > > *** [readelf.o] Error code 1 > > > > > Sure, the "the other hunk" missing from this revert, but it is fixed now by > a different commit. Yes, email race condition. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903281924.x2SJOFiJ042178>