From owner-freebsd-arch Fri Apr 26 9: 0:21 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 4C07837B41C; Fri, 26 Apr 2002 09:00:10 -0700 (PDT) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g3QG08H96928; Fri, 26 Apr 2002 10:00:08 -0600 (MDT) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g3QG07b48822; Fri, 26 Apr 2002 10:00:07 -0600 (MDT) (envelope-from imp@village.org) Date: Fri, 26 Apr 2002 09:59:55 -0600 (MDT) Message-Id: <20020426.095955.80136029.imp@village.org> To: drosih@rpi.edu Cc: areilly@bigpond.net.au, arch@FreeBSD.ORG, freebsd-standards@FreeBSD.ORG Subject: Re: diff & patch problem with 'No newline' From: "M. Warner Losh" In-Reply-To: References: <1019819253.450.389.camel@gurney.reilly.home> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: Garance A Drosihn writes: : At 9:07 PM +1000 4/26/02, Andrew Reilly wrote: : >On Fri, 2002-04-26 at 14:12, Garance A Drosihn wrote: : >> So, that's my pitch. I feel fairly strongly that there is a : >> real advantage in following the lead of Linux (+anyone using : > > gnu-diff) and NetBSD in this matter. : > : >I know that you didn't ask for it, but I'd like to voice a : >strong vote of "yea" for (at least) teaching our patch to : >handle the "\no new line" in diffs. : : I'm willing to ask for any votes of "yea". It's the votes : of "nay" that I'm not asking for... :-) :-) My plans had always been to back out Green's change (with Green's permission, btw) when there was a patch that could grok things. The back out wouldn't be MFC'd until after at least one release. Since this was historical FreeBSD behavior, and modern patches grok the end of line things, I see this as a no brainer: just do it once patch is patched :-) Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message