From owner-cvs-all@FreeBSD.ORG Thu Jun 29 22:56:50 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B1A216A412; Thu, 29 Jun 2006 22:56:45 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9249E446C6; Thu, 29 Jun 2006 19:22:05 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k5TJM580007315; Thu, 29 Jun 2006 19:22:05 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k5TJM5ev007314; Thu, 29 Jun 2006 19:22:05 GMT (envelope-from yar) Message-Id: <200606291922.k5TJM5ev007314@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 29 Jun 2006 19:22:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if.c if_atmsubr.c if_stf.c if_tun.c src/sys/netinet if_ether.c ip_divert.c ip_fw2.c src/sys/netinet6 in6.c in6_var.h src/sys/nfsclient bootp_subr.c nfs_diskless.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2006 22:56:50 -0000 yar 2006-06-29 19:22:05 UTC FreeBSD src repository Modified files: sys/net if.c if_atmsubr.c if_stf.c if_tun.c sys/netinet if_ether.c ip_divert.c ip_fw2.c sys/netinet6 in6.c in6_var.h sys/nfsclient bootp_subr.c nfs_diskless.c Log: There is a consensus that ifaddr.ifa_addr should never be NULL, except in places dealing with ifaddr creation or destruction; and in such special places incomplete ifaddrs should never be linked to system-wide data structures. Therefore we can eliminate all the superfluous checks for "ifa->ifa_addr != NULL" and get ready to the system crashing honestly instead of masking possible bugs. Suggested by: glebius, jhb, ru Revision Changes Path 1.260 +4 -6 src/sys/net/if.c 1.43 +2 -2 src/sys/net/if_atmsubr.c 1.56 +0 -2 src/sys/net/if_stf.c 1.157 +13 -18 src/sys/net/if_tun.c 1.153 +1 -1 src/sys/netinet/if_ether.c 1.119 +0 -2 src/sys/netinet/ip_divert.c 1.140 +0 -4 src/sys/netinet/ip_fw2.c 1.62 +0 -6 src/sys/netinet6/in6.c 1.29 +0 -2 src/sys/netinet6/in6_var.h 1.66 +5 -4 src/sys/nfsclient/bootp_subr.c 1.16 +2 -2 src/sys/nfsclient/nfs_diskless.c