From owner-svn-src-head@FreeBSD.ORG Sat Jan 31 18:06:34 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D20310656BC; Sat, 31 Jan 2009 18:06:34 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 6AB128FC08; Sat, 31 Jan 2009 18:06:34 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n0VI6YQH030779; Sat, 31 Jan 2009 18:06:34 GMT (envelope-from bz@svn.freebsd.org) Received: (from bz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n0VI6Yh9030777; Sat, 31 Jan 2009 18:06:34 GMT (envelope-from bz@svn.freebsd.org) Message-Id: <200901311806.n0VI6Yh9030777@svn.freebsd.org> From: "Bjoern A. Zeeb" Date: Sat, 31 Jan 2009 18:06:34 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r187960 - in head/sys/fs: nwfs smbfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jan 2009 18:06:34 -0000 Author: bz Date: Sat Jan 31 18:06:34 2009 New Revision: 187960 URL: http://svn.freebsd.org/changeset/base/187960 Log: After r186194 the *fs_strategy() functions always return 0. So we are no longer interested in the error returned from the *fs_doio() functions. With that we can remove the error variable as its value is unused now. Submitted by: Christoph Mallon christoph.mallon@gmx.de Modified: head/sys/fs/nwfs/nwfs_vnops.c head/sys/fs/smbfs/smbfs_vnops.c Modified: head/sys/fs/nwfs/nwfs_vnops.c ============================================================================== --- head/sys/fs/nwfs/nwfs_vnops.c Sat Jan 31 17:36:22 2009 (r187959) +++ head/sys/fs/nwfs/nwfs_vnops.c Sat Jan 31 18:06:34 2009 (r187960) @@ -784,7 +784,6 @@ static int nwfs_strategy (ap) struct buf *bp=ap->a_bp; struct ucred *cr; struct thread *td; - int error = 0; NCPVNDEBUG("\n"); if (bp->b_flags & B_ASYNC) @@ -801,7 +800,7 @@ static int nwfs_strategy (ap) * otherwise just do it ourselves. */ if ((bp->b_flags & B_ASYNC) == 0 ) - error = nwfs_doio(ap->a_vp, bp, cr, td); + (void)nwfs_doio(ap->a_vp, bp, cr, td); return (0); } Modified: head/sys/fs/smbfs/smbfs_vnops.c ============================================================================== --- head/sys/fs/smbfs/smbfs_vnops.c Sat Jan 31 17:36:22 2009 (r187959) +++ head/sys/fs/smbfs/smbfs_vnops.c Sat Jan 31 18:06:34 2009 (r187960) @@ -850,7 +850,6 @@ smbfs_strategy (ap) struct buf *bp=ap->a_bp; struct ucred *cr; struct thread *td; - int error = 0; SMBVDEBUG("\n"); if (bp->b_flags & B_ASYNC) @@ -863,7 +862,7 @@ smbfs_strategy (ap) cr = bp->b_wcred; if ((bp->b_flags & B_ASYNC) == 0 ) - error = smbfs_doio(ap->a_vp, bp, cr, td); + (void)smbfs_doio(ap->a_vp, bp, cr, td); return (0); }