Date: Thu, 18 Dec 2014 09:52:03 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: marino@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>, Alex Kozlov <ak@FreeBSD.org> Subject: Re: svn commit: r374800 - head/Mk/Uses Message-ID: <5492F823.2040705@FreeBSD.org> In-Reply-To: <5492C1C8.6020308@marino.st> References: <201412161206.sBGC6fa5045717@svn.freebsd.org> <54902709.9090801@marino.st> <71EBD6FD6D89266B6651554A@ogg.in.absolight.net> <20141216133802.GA27647@ravenloft.kiev.ua> <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net> <20141216141320.GA28332@ravenloft.kiev.ua> <20141216142422.GA38033@FreeBSD.org> <5490DFDB.5080000@FreeBSD.org> <20141218111154.GA21894@ivaldir.etoilebsd.net> <5492C1C8.6020308@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IHBWeK53LQDHqS9GgOqWf9FFP9X5ahLwW Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/18/2014 6:00 AM, John Marino wrote: > On 12/18/2014 12:11, Baptiste Daroussin wrote: >> On Tue, Dec 16, 2014 at 07:43:55PM -0600, Bryan Drewery wrote: >>> On 12/16/2014 8:24 AM, Alexey Dokuchaev wrote: >>>> On Tue, Dec 16, 2014 at 04:13:20PM +0200, Alex Kozlov wrote: >>>>> On Tue, Dec 16, 2014 at 02:47:09PM +0100, Mathieu Arnold wrote: >>>>>> +--On 16 d'ecembre 2014 15:38:02 +0200 Alex Kozlov <ak@FreeBSD.org= > wrote: >>>>>> | Allow me to ask, why it should be 8 and not 4? >>>>>> >>>>>> Because a tabulation is 8 spaces. It should be consistent over th= e whole >>>>>> ports tree. >>>>> >>>>> Well, 'Please view me with 4 column tabs!' line was added to bsd.po= rt.mk >>>>> more than 20 year ago, in rev 69, because it's inconvenient to view= it with >>>>> default tabulation value: many wrapped lines, indentation too deep,= etc. >>>> >>>> I think I agree with Alex here. While most of us prefer ts=3D8, I d= on't see >>>> the need to reindent some files, most notably b.p.m., as it will com= pletely >>>> jeopardize its history and make 'svn blame' basically useless. >>>> >>>> Even with editors that cannot grok ex:ts=3DX hints, its not that har= d to do it >>>> manually every time you need to view/edit these files. I do it all = the time >>>> with nvi(1). >>>> >>>> ./danfe >>>> >>> >>> As a vendor who maintains a forked ports tree, I despise this commit = and >>> all of the ones below. It makes carrying out customizations very >>> difficult. Yes, it doesn't *look* good on the eyes, but reindenting o= n >>> such large files with large history maintained by > 1 person is a sin= =2E >>> >>> >> Wow that makes impressive to quote that whole list of commits, among t= hose >> changes a few are really changing things more than a few comments, and= most of >> which are files that are either removed and/or heavily worked on at th= e time, >> there are yes 1 or 2 maybe controversial here but that is all. >> >=20 > I'm a bit disappointed that "svn blame" output is considered more > important than doing the right thing, myself. It's a tool, not a > constitutional by-law. Just fix all the Mk files at once. >=20 > John >=20 I actually thought that had already been done by bapt and am now surprised we're dealing with it again/still. --=20 Regards, Bryan Drewery --IHBWeK53LQDHqS9GgOqWf9FFP9X5ahLwW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUkvgjAAoJEDXXcbtuRpfP5nAH/if6koTHNE8LaEcC9vJ1ZRjo OpUypf9MykBiUD9VtSCua5sw/WHhGinS8NHIlF3Kb5cFU9a3MM2SgEBqOO9Y3iew oWtySyyb2SwcXUZBV5VxwfJdTPEAnJLDl1pL+GMGeoqsb3zsT0Dqb4RmNdwPkDJQ KplvJlJEqljzyBce74NX2/t7FAfarhsK0Ewsbe3L0CIUwdJQfgbKxUQuC7uaNn2B c92XpcINiDl4yGfmNwNmHmTA+o1MEc/bF9QYpFTnlKzQ6r7m94SxC1vZ6QWlaQsy rJ6q8E02r69EyrEUtbNfsSC//IlYT9oGpx2l8AjOReSLmiCyUtBtxRof4vkQUeQ= =Ubgq -----END PGP SIGNATURE----- --IHBWeK53LQDHqS9GgOqWf9FFP9X5ahLwW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5492F823.2040705>