Date: Sat, 21 Nov 2015 01:35:41 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: "Sergey V. Dyatko" <sergey.dyatko@gmail.com>, freebsd-current@freebsd.org Subject: Re: /bin/ls formatting broken for non-C(?) locales Message-ID: <20151121003541.GF21071@ivaldir.etoilebsd.net> In-Reply-To: <20151120122352.GA5751@stack.nl> References: <20151120110556.6e20a71f@laptop.minsk.domain> <20151120104253.GA21071@ivaldir.etoilebsd.net> <20151120110212.GB21071@ivaldir.etoilebsd.net> <20151120122352.GA5751@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--XIiC+We3v3zHqZ6Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 20, 2015 at 01:23:52PM +0100, Jilles Tjoelker wrote: > On Fri, Nov 20, 2015 at 12:02:13PM +0100, Baptiste Daroussin wrote: > > On Fri, Nov 20, 2015 at 11:42:53AM +0100, Baptiste Daroussin wrote: > > > On Fri, Nov 20, 2015 at 11:05:56AM +0300, Sergey V. Dyatko wrote: > > > > subj. http://i.imgur.com/F9QO29l.png > > > > it is on head@r290573: > > > > WTR: > > > > env LC_ALL=3Duk_UA.UTF-8 ls -la /usr/ports/databases/ or env LC_ALL= =3Dru_RU.UTF-8 > > > > ls -la /usr/ports/databases/ >=20 > > > > env LC_ALL=3DC ls -la /usr/ports/databases/ works fine > > > > also on old stable/10 (r286868) as I can see 'month' field length = 3 symbols=20 >=20 > > > Thanks for reporting, I can reproduce the issue with some other > > > locales. The thing is there seems to be no standard for abbreviated > > > length. Formerly we had a 3 character lenght for abbreviated month. >=20 > > > We now use CLDR which seems to follow the abbreviated rules from IBM: > > > "Each string must be of equal length and contain 5 characters or less" >=20 > > > There are 2 possible fixes: either always pad those in the locale > > > definition which seems wrong or modify ls so that it by itself pads > > > properly. >=20 > > > Neither posix nor ISO-14652 defines the length of the abbreviated form >=20 > > > padding in the locales themself would be wrong so I do propose to > > > pad in the ls command. And padding with 5 characters. >=20 > > For the record glibc/linux had the same problem: > > https://sourceware.org/bugzilla/show_bug.cgi?id=3D9859 >=20 > > "fixed" in coreutils (gnu ls) the way I propose to do for us > > http://git.savannah.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommit;h=3D61= 2b647dd16d5abc03b295abe42d8b4a0fe660f7 >=20 > Coreutils fixed it slightly better: it calculates the maximum width of > the abbreviated month names and pads to that (with a maximum of 5). In > particular, this ensures that the output does not change for locales > that have 3-character abbreviations, such as the POSIX locale. I think > this is valuable. >=20 > They also keep the list of month names from this calculation and they > say this speeds up ls noticeably compared to having strftime() expand %b > for every file. Here is what I do propose (sorry for the ugly pad_to_col name, if one has b= etter please share :D https://reviews.freebsd.org/D4239 Best regards, Bapt --XIiC+We3v3zHqZ6Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlZPvF0ACgkQ8kTtMUmk6Ex2lQCbBT6irike5A4NGCDAt4aLmR6W lwoAniJw4ESDV4OI5gZd+E4y+HdTRrT8 =AXP7 -----END PGP SIGNATURE----- --XIiC+We3v3zHqZ6Z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151121003541.GF21071>