From owner-svn-src-head@freebsd.org Mon Mar 30 01:51:00 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F69426B9A2; Mon, 30 Mar 2020 01:51:00 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48rFmJ292tz4bhJ; Mon, 30 Mar 2020 01:50:56 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 02U1Ofnj053694; Sun, 29 Mar 2020 18:24:41 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 02U1OfCx053693; Sun, 29 Mar 2020 18:24:41 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202003300124.02U1OfCx053693@gndrsh.dnsmgr.net> Subject: Re: svn commit: r359426 - head/usr.bin/kyua In-Reply-To: <202003291948.02TJmTbX066949@repo.freebsd.org> To: Brooks Davis Date: Sun, 29 Mar 2020 18:24:41 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 48rFmJ292tz4bhJ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 01:51:00 -0000 > Author: brooks > Date: Sun Mar 29 19:48:28 2020 > New Revision: 359426 > URL: https://svnweb.freebsd.org/changeset/base/359426 > > Log: > Fix build with src on a noexec filesystem. > > ${SH} expands to nothing on src builds so this worked by accident. Use > a bare "sh" instead. Correct variable in BSD mk is ${SHELL} > > PR: 245086 > Reported by: pkubaj > Sponsored by: DARPA > > Modified: > head/usr.bin/kyua/Makefile > > Modified: head/usr.bin/kyua/Makefile > ============================================================================== > --- head/usr.bin/kyua/Makefile Sun Mar 29 19:16:14 2020 (r359425) > +++ head/usr.bin/kyua/Makefile Sun Mar 29 19:48:28 2020 (r359426) > @@ -52,7 +52,7 @@ CLEANFILES+= ${MAN} > .PATH: ${KYUA_SRCDIR}/doc > .for man in ${MAN} > ${man}: ${man}.in > - ${SH} ${KYUA_SRCDIR}/doc/manbuild.sh \ > + sh ${KYUA_SRCDIR}/doc/manbuild.sh \ > -v "CONFDIR=${KYUA_CONFDIR}" \ > -v "DOCDIR=${KYUA_DOCDIR}" \ > -v "EGDIR=${KYUA_EGDIR}" \ > -- Rod Grimes rgrimes@freebsd.org