From owner-freebsd-arch@FreeBSD.ORG Thu Oct 7 17:52:36 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7591A1065696; Thu, 7 Oct 2010 17:52:36 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119]) by mx1.freebsd.org (Postfix) with ESMTP id 4950E8FC14; Thu, 7 Oct 2010 17:52:36 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 9AEA6582EC; Thu, 7 Oct 2010 12:34:22 -0500 (CDT) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from mail.icecube.wisc.edu ([127.0.0.1]) by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id fsABixJKwugS; Thu, 7 Oct 2010 12:34:22 -0500 (CDT) Received: from comporellon.tachypleus.net (adsl-75-50-91-12.dsl.mdsnwi.sbcglobal.net [75.50.91.12]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 3F296582E9; Thu, 7 Oct 2010 12:34:22 -0500 (CDT) Message-ID: <4CAE049D.2090603@freebsd.org> Date: Thu, 07 Oct 2010 12:34:21 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.12) Gecko/20100925 Thunderbird/3.0.8 MIME-Version: 1.0 To: mdf@FreeBSD.org References: <20101007161338.GK2392@deviant.kiev.zoral.com.ua> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Kostik Belousov , FreeBSD Arch Subject: Re: freebsd32_ioctl.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2010 17:52:36 -0000 On 10/07/10 12:02, mdf@FreeBSD.org wrote: >>> Should we >>> just be adding ioctl argument munging as we go along and not worry >>> about the size? Or is there simple way to keep the munging inside the >>> driver? Perhaps my making the driver's ioctl look something like: >>> >> I think that in-driver variant is the best. >> > Okay, I am trying this approach. > > >> if (SV_CURPROC_FLAG(SV_ILP32)) >> > That's what I get for doing development on stable/7. I miss out on > the existence of such handy things. > Also bear in mind that freebsd32 is also used on powerpc64 to run 32-bit ppc binaries, so testing for IA32 probably isn't what you want, anyway. -Nathan