From owner-freebsd-wireless@FreeBSD.ORG  Tue Apr  3 11:37:01 2012
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8967F106566C
	for <freebsd-wireless@freebsd.org>;
	Tue,  3 Apr 2012 11:37:01 +0000 (UTC)
	(envelope-from bschmidt@techwires.net)
Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com
	[209.85.215.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 004F38FC0C
	for <freebsd-wireless@freebsd.org>;
	Tue,  3 Apr 2012 11:37:00 +0000 (UTC)
Received: by lagv3 with SMTP id v3so6321755lag.13
	for <freebsd-wireless@freebsd.org>;
	Tue, 03 Apr 2012 04:36:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=mime-version:sender:x-originating-ip:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:x-gm-message-state;
	bh=ICpJK8+B7PKKPfM5VspYhVyfczuv2MDMl/mv/TRJEeU=;
	b=H48v4bW0wlqdPcWcWygzIkHfvjTsVcc36CdTpOkVaOKCZm2ouGs+v5VeBr4XQwkt6L
	SFnZjnKObIj462k6Nq6wvMFpU1sGCqhOUTD4ss+hNUs5Z/wwLRyaWwXLL1aMiKSg6O8E
	SeKToHcUDVGE73dICz/5leW6FYuQVPBm7q9UVnaorsFOyJ0jda0lUZRokGtwzj7myYh6
	Be0pUPoKj064oZl2klkL1U+k45ekTHId5WISCyz+DvSbi7pkBRkRlPWNWpI3kjVxYmwI
	n2j+/S3MQ/3mfz5IbXKWZCQURH1fJ9vUPDwJ55hhuUt7f/TWrw5yT/3mfj05rvr6rklQ
	TWHg==
MIME-Version: 1.0
Received: by 10.152.104.43 with SMTP id gb11mr13729772lab.8.1333453019604;
	Tue, 03 Apr 2012 04:36:59 -0700 (PDT)
Sender: bschmidt@techwires.net
Received: by 10.152.112.38 with HTTP; Tue, 3 Apr 2012 04:36:59 -0700 (PDT)
X-Originating-IP: [79.140.39.245]
In-Reply-To: <20120403.200327.18305192.iwasaki@jp.FreeBSD.org>
References: <20120403.200327.18305192.iwasaki@jp.FreeBSD.org>
Date: Tue, 3 Apr 2012 13:36:59 +0200
X-Google-Sender-Auth: FniK3ZbcpEpZp-aTMsL3O0Okk8I
Message-ID: <CAAgh0_ZuJ_dG-r7QnLRJ-NX8Ejmt1DpBehgYOMv-pt_tT4K0Yg@mail.gmail.com>
From: Bernhard Schmidt <bschmidt@freebsd.org>
To: Mitsuru IWASAKI <iwasaki@jp.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQnZV59Xt4le/QL6seav343Bbmw8IaHUYadyvUbF16ka5PQxBctFPsppIROOQuoBs5nltHyS
Cc: freebsd-wireless@freebsd.org
Subject: Re: [patch] iwi(4) watchdog broken
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 11:37:01 -0000

On Tue, Apr 3, 2012 at 13:03, Mitsuru IWASAKI <iwasaki@jp.freebsd.org> wrote:
> Hi,
>
> Suspend/Resume problem was solved (thanks bschmidt!),
> however problem still remainds after watchdog messages like
> `device timeout' or `firmware stuck in state 4, resetting'.

Honestly, I'd rather see the above issues fixed and not the workaround
for it. ;)
Do you have a test case to reproduce this?

> I've made patches against not only iwi(4) but also net8011 code
> and tested for few days;
> http://people.freebsd.org/~iwasaki/iwi/iwi-20120403.diff
>
> Please review the patches, Thanks!

So, if I get that correctly, the only difference is that you added a
ieee80211_new_state_locked(vap, IEEE80211_S_INIT, -1); call, right?
Any reason why not calling ieee80211_stop_all()/ieee80211_start_all()
directly in iwi_restart()? This will call the appropriate
iwi_init/stop functions.

-- 
Bernhard