From owner-svn-src-all@freebsd.org Wed Dec 16 19:41:26 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6C1DA49C49; Wed, 16 Dec 2015 19:41:26 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pf0-x233.google.com (mail-pf0-x233.google.com [IPv6:2607:f8b0:400e:c00::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E1741844; Wed, 16 Dec 2015 19:41:26 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pf0-x233.google.com with SMTP id v86so16978455pfa.2; Wed, 16 Dec 2015 11:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=nmX081NQVe3hK8L5NNYrgbXVMJN6ghdaZntxszv30g4=; b=O2cy8XnnMRQVCxKTagxlyegMXDqA2xnxCghUWzReH2V9fltpOq/g12uBiqLDa/aoG3 T13IteW+K3hE9sV05eFChQwNolBd5RIj28OXrDQ0EDGUCnIGXRTCRDPJ/76HpDEL/vxQ pygu7zR3huWSjLo5xMw6qPRutHRwJzShqGK5H7YWc+i9QaVTrUoUah8zSlXmGw6ZiydY Aw12CwzGmkrrOEmsgPy7Lv6dR6Eh0DdfEfy5GPfsGGh4OuHVbjfJSBzt9dQxPIP0q20P H9fKtn5ede26vM41i27NWC0Y0YO353WMcDnt5EW0YifTW643vit+aUdxXtzcYNvVPgve Np1g== X-Received: by 10.98.74.77 with SMTP id x74mr8339137pfa.102.1450294886207; Wed, 16 Dec 2015 11:41:26 -0800 (PST) Received: from ox ([2601:641:c000:600:224:d7ff:fe08:23a0]) by smtp.gmail.com with ESMTPSA id sg4sm10860661pac.48.2015.12.16.11.41.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Dec 2015 11:41:24 -0800 (PST) Date: Wed, 16 Dec 2015 11:41:22 -0800 From: Navdeep Parhar To: John Baldwin Cc: Randall Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks Message-ID: <20151216194122.GC21462@ox> Mail-Followup-To: John Baldwin , Randall Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201512160056.tBG0ujqA067178@repo.freebsd.org> <1972466.CRnu3P14jO@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1972466.CRnu3P14jO@ralph.baldwin.cx> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2015 19:41:26 -0000 On Wed, Dec 16, 2015 at 07:06:31AM -0800, John Baldwin wrote: > On Wednesday, December 16, 2015 12:56:45 AM Randall Stewart wrote: > > Author: rrs > > Date: Wed Dec 16 00:56:45 2015 > > New Revision: 292309 > > URL: https://svnweb.freebsd.org/changeset/base/292309 > > > > Log: > > First cut of the modularization of our TCP stack. Still > > to do is to clean up the timer handling using the async-drain. > > Other optimizations may be coming to go with this. Whats here > > will allow differnet tcp implementations (one included). > > Reviewed by: jtl, hiren, transports > > Sponsored by: Netflix Inc. > > Differential Revision: D4055 > > Have you considered treating TOE as a separate stack? We already > have a bit of a split to handle TOE specially. It might be nice if > it was able to plug in via this. That might also help flesh out the > abstraction a bit by giving another use case. That's an interesting thought. The TOE code should be a great test for any KPI that aims to allow multiple TCP stacks to coexist (TOEs are nothing but alternate TCP stacks running in the hardware). The only oddball thing about TOE is that the offload vs don't offload decision is made on the fly (based on the route lookup) and not when the socket is created. Regards, Navdeep > > Also, note that the Differential Revision tag should be the full > URL to the review (in which case it auto-closes it for you). > > -- > John Baldwin >