From owner-cvs-all Wed Jul 17 4:47:34 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D45337B400; Wed, 17 Jul 2002 04:47:25 -0700 (PDT) Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73E9C43E31; Wed, 17 Jul 2002 04:47:23 -0700 (PDT) (envelope-from sheldonh@starjuice.net) Received: from sheldonh by axl.seasidesoftware.co.za with local (Exim 3.36 #1) id 17UnIP-0007Cf-00; Wed, 17 Jul 2002 13:48:41 +0200 Date: Wed, 17 Jul 2002 13:48:41 +0200 From: Sheldon Hearn To: Kirk McKusick Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, des@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c vfs_syscalls.c src/sys/ufs/ufs ufs_vnops.c src/lib/libc/sys utimes.2 src/sbin/restore dirs.c restore.h tape.c src/sbin/dump traverse.c src/include/protocols dumprestore.h Message-ID: <20020717114841.GC49613@starjuice.net> Mail-Followup-To: Kirk McKusick , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, des@FreeBSD.org References: <200207170203.g6H23JCI026708@freefall.freebsd.org> <20020717065102.GB43192@starjuice.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020717065102.GB43192@starjuice.net> User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On (2002/07/17 08:51), Sheldon Hearn wrote: > > Log: > > Change utimes to set the file creation time (for filesystems that > > support creation times such as UFS2) to the value of the > > modification time if the value of the modification time is older > > than the current creation time. See utimes(2) for further details. > > Did I miss a follow-up commit that fixed the following world breakage: [...] The renaming of createtime* to birthtime* seem to have broken the build of newfs and dump. I think the following patches are required. DES, I copied you on this because this breakage showed up in your tinderbox report. Ciao, Sheldon. Index: sbin/newfs/mkfs.c =================================================================== RCS file: /home/ncvs/src/sbin/newfs/mkfs.c,v retrieving revision 1.59 diff -u -d -r1.59 mkfs.c --- sbin/newfs/mkfs.c 11 Jul 2002 17:49:41 -0000 1.59 +++ sbin/newfs/mkfs.c 17 Jul 2002 11:44:57 -0000 @@ -708,7 +708,7 @@ node.dp2.di_atime = utime; node.dp2.di_mtime = utime; node.dp2.di_ctime = utime; - node.dp2.di_createtime = utime; + node.dp2.di_birthtime = utime; /* * create the root directory */ Index: include/protocols/dumprestore.h =================================================================== RCS file: /home/ncvs/src/include/protocols/dumprestore.h,v retrieving revision 1.9 diff -u -d -r1.9 dumprestore.h --- include/protocols/dumprestore.h 21 Jun 2002 06:17:46 -0000 1.9 +++ include/protocols/dumprestore.h 17 Jul 2002 11:44:57 -0000 @@ -93,8 +93,8 @@ int32_t c_mtimensec; /* last modified time, nanosecs */ int32_t c_spare2[2]; /* old ctime */ int32_t c_rdev; /* for devices, device number */ - int32_t c_createtimensec; /* creation time, nanosecs */ - int64_t c_createtime; /* creation time, seconds */ + int32_t c_birthtimensec; /* creation time, nanosecs */ + int64_t c_birthtime; /* creation time, seconds */ int64_t c_atime; /* last access time, seconds */ int64_t c_mtime; /* last modified time, seconds */ int32_t c_spare4[7]; /* old block pointers */ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message