Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Nov 2015 18:16:10 +0000 (UTC)
From:      Zbigniew Bodek <zbb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r291401 - head/sys/boot/usb/storage
Message-ID:  <201511271816.tARIGAO3018952@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: zbb
Date: Fri Nov 27 18:16:10 2015
New Revision: 291401
URL: https://svnweb.freebsd.org/changeset/base/291401

Log:
  Do not zero memory in umass_detach
  
  The detach function is called very often, for example from
  get_capacity function. We don't want to loose any pointers
  here, so disable detaching for umass driver.
  
  Submitted by:  Wojciech Macek <wma@semihalf.com>
  Obtained from: Semihalf
  Sponsored by:  Juniper Networks Inc.
  Differential Revision: https://reviews.freebsd.org/D4141

Modified:
  head/sys/boot/usb/storage/umass_common.c

Modified: head/sys/boot/usb/storage/umass_common.c
==============================================================================
--- head/sys/boot/usb/storage/umass_common.c	Fri Nov 27 18:14:45 2015	(r291400)
+++ head/sys/boot/usb/storage/umass_common.c	Fri Nov 27 18:16:10 2015	(r291401)
@@ -82,6 +82,9 @@ umass_attach(device_t dev)
 static int
 umass_detach(device_t dev)
 {
+
+#ifdef USB_DEBUG
 	memset(&umass_uaa, 0, sizeof(umass_uaa));
+#endif
 	return (0);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201511271816.tARIGAO3018952>