From owner-svn-src-all@freebsd.org Sat Sep 9 21:51:12 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24556E0C790; Sat, 9 Sep 2017 21:51:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A3C6F7EE02; Sat, 9 Sep 2017 21:51:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v89Lp0MD094748 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 10 Sep 2017 00:51:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v89Lp0MD094748 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v89Lp0PP094747; Sun, 10 Sep 2017 00:51:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 10 Sep 2017 00:51:00 +0300 From: Konstantin Belousov To: "Ngie Cooper (yaneurabeya)" Cc: Jonathan Anderson , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323365 - in head: cddl/lib/libzpool gnu/usr.bin/binutils/libbfd usr.bin/svn/lib/libsvn_client Message-ID: <20170909215100.GX1700@kib.kiev.ua> References: <201709091318.v89DIXDj027788@repo.freebsd.org> <20170909183518.GV1700@kib.kiev.ua> <23674A3F-E627-4873-8BB6-4F5ADD7E3EA7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23674A3F-E627-4873-8BB6-4F5ADD7E3EA7@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Sep 2017 21:51:12 -0000 On Sat, Sep 09, 2017 at 12:56:20PM -0700, Ngie Cooper (yaneurabeya) wrote: > > > On Sep 9, 2017, at 11:35, Konstantin Belousov wrote: > > > > On Sat, Sep 09, 2017 at 01:18:33PM +0000, Jonathan Anderson wrote: > >> Author: jonathan > >> Date: Sat Sep 9 13:18:32 2017 > >> New Revision: 323365 > >> URL: https://svnweb.freebsd.org/changeset/base/323365 > >> > >> Log: > >> Remove redundant source and object files. > > > >> Modified: head/gnu/usr.bin/binutils/libbfd/Makefile.amd64 > >> ============================================================================== > >> --- head/gnu/usr.bin/binutils/libbfd/Makefile.amd64 Sat Sep 9 12:50:12 2017 (r323364) > >> +++ head/gnu/usr.bin/binutils/libbfd/Makefile.amd64 Sat Sep 9 13:18:32 2017 (r323365) > >> @@ -9,7 +9,6 @@ DEFAULT_VECTOR= bfd_elf64_x86_64_freebsd_vec > >> > >> SRCS+= elf64-x86-64.c \ > >> efi-app-x86_64.c \ > >> - efi-app-ia32.c \ > >> elf64.c \ > >> elf64-gen.c \ > >> elf64-target.h \ > > Why did you claimed that x86 efi binfmt is redundant ? > > It???s redundant because of how the Makefile gets .include???d (amd64 requires i386???s Makefile). > Cheers, > -Ngie > > $ grep -r efi-app gnu/usr.bin/binutils/libbfd/ > gnu/usr.bin/binutils/libbfd/Makefile.amd64: efi-app-x86_64.c \ > gnu/usr.bin/binutils/libbfd/Makefile.amd64: efi-app-ia32.c \ > gnu/usr.bin/binutils/libbfd/Makefile.i386: efi-app-ia32.c \ > $ grep include gnu/usr.bin/binutils/libbfd/Makefile.amd64 > .include "${.CURDIR}/Makefile.i386??? Then, why peigen.c was left in the SRCS ?