From owner-cvs-all@FreeBSD.ORG Thu Oct 21 18:34:40 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6A8316A4D0; Thu, 21 Oct 2004 18:34:40 +0000 (GMT) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8588443D2D; Thu, 21 Oct 2004 18:34:40 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i9LIYdGI001310; Thu, 21 Oct 2004 14:34:39 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200410211702.i9LH2cQq057419@repoman.freebsd.org> References: <200410211702.i9LH2cQq057419@repoman.freebsd.org> Date: Thu, 21 Oct 2004 14:34:37 -0400 To: Colin Percival , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) Subject: Re: cvs commit: src/usr.bin/xargs strnsubst.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 18:34:41 -0000 At 5:02 PM +0000 10/21/04, Colin Percival wrote: >cperciva 2004-10-21 17:02:38 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5) > usr.bin/xargs strnsubst.c > Log: > Fix a buffer overflow. This is the same bug as is corrected in rev. > 1.7, but the correction is different: Rather than making sure the > string we're constructing doesn't grow too large, we realloc() to > make sure the buffer is large enough. > > This violates the IEEE Std 1003.1-2004 standard, but retains > backwards compatability. Thanks. I think this is a much better solution! -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu