Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Nov 2002 17:16:14 -0800 (PST)
From:      Archie Cobbs <archie@dellroad.org>
To:        Daniel Eischen <eischen@pcnet1.pcnet.com>
Cc:        Archie Cobbs <archie@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc_r/uthread uthread_execve.c
Message-ID:  <200211150116.gAF1GEhq032365@arch20m.dellroad.org>
In-Reply-To: <Pine.GSO.4.10.10211141954130.13722-100000@pcnet1.pcnet.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Daniel Eischen wrote:
> >   Modified files:
> >     lib/libc_r/uthread   uthread_execve.c 
> >   Log:
> >   When about to do an execve(), don't reset the O_NONBLOCK flag on any file
> >   descriptors that have the close-on-exec flag set, as that will have no
> >   effect anyway and might screw something else up if the file descriptor
> >   happens to be shared with another process.
> 
> I didn't like this change.  It was a hack to cover up some other
> problem.

But it was harmless, right? I figured it fixes some corner case without
causing any additional bugs so why not?

The real underlying problem doesn't seem solvable; I'd rather wait
until libc_r is KSE'ified.

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200211150116.gAF1GEhq032365>