Date: Mon, 18 May 1998 23:06:22 +0200 (MET DST) From: Guido van Rooij <guido@gvr.org> To: bde@zeta.org.au (Bruce Evans) Cc: guido@FreeBSD.ORG, jhay@mikom.csir.co.za, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet tcp_input.c Message-ID: <199805182106.XAA08920@gvr.gvr.org> In-Reply-To: <199805182054.GAA30065@godzilla.zeta.org.au> from Bruce Evans at "May 19, 98 06:54:52 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > >> guido 1998/05/18 10:07:59 PDT > >> > >> Modified files: > >> sys/netinet tcp_input.c > >> Log: > >> Add some parenthesis for clarity and fix a bug > >> Pointed out by: Garrett Wollmand > > ^ > >Shouldn't you also add this to rc.network so that it can start > >automatically on new machines? :-) > > Then you should also add the bd :-). It deletes parentheses for > clarity. Its review of this patch: "2 extra layers of parentheses > is 2 more layers than I would use and 1 more layer than KNF. This > change has no affect on the object code. Where is the bug fix?". > See the next commit (t_state -> t_flags). The whole commit would not have been done if it wasn't for the bugfix. Somehow that got left out :-( Somehow, I suspect the bd to automatically send email to every commit, randomly poking at parts from the commit and throwing a couple of "there's a style bug in there" to you. When assembly is involved, it usually also magically comes up with the amount of clock cycles the change adds. The funny thing is, that the comments are mostly true.... -Guido To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805182106.XAA08920>