Date: Thu, 23 Aug 2001 22:39:37 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: =?koi8-r?Q?S=F8ren?= Schmidt <sos@freebsd.dk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfs nfs_lock.c Message-ID: <20010823223936.A571@nagual.pp.ru> In-Reply-To: <200108231822.f7NIMQ668039@freebsd.dk> References: <200108231802.f7NI2TJ22312@freefall.freebsd.org> <200108231822.f7NIMQ668039@freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 23, 2001 at 20:22:21 +0200, Søren Schmidt wrote: > It seems Andrey A. Chernov wrote: > > Excuse me asking, but could we have you do all this testing > and bugfixing etc BEFORE you start to commit things ?? > We have now had a dozen or so "oops forgot this forgot that" > commits all day long, its getting tiresome... Only two 'oops' today. All other for implementing just different parts we don't even have before (EOVERFLOW, l_len<0), cosmetique, spelling, etc. I prefer small portions over mega-commits with several features at once. My local tests works, but it is difficult to test full implications of overflow handling, some fixes come from the people feedback (which I don't have when post CFR into arch@) > Another thing is that this new POSIX behavior breaks some > apps, take mpg123 as an example, it doesn't work anymore.... It means that app must be fixed. POSIX is POSIX. Unless there is mistake from my side. Check if your vfs_syscalls.c is v1.201 at least - there was a bug in the code I blindly copy from bde suggestion which breaks lseek SEEK_END badly. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010823223936.A571>