From owner-freebsd-current Sun Sep 8 14:39:49 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA26352 for current-outgoing; Sun, 8 Sep 1996 14:39:49 -0700 (PDT) Received: from po2.glue.umd.edu (po2.glue.umd.edu [129.2.128.45]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id OAA26339 for ; Sun, 8 Sep 1996 14:39:43 -0700 (PDT) Received: from professor.eng.umd.edu (professor.eng.umd.edu [129.2.103.23]) by po2.glue.umd.edu (8.7.5/8.7.3) with ESMTP id RAA20907; Sun, 8 Sep 1996 17:39:40 -0400 (EDT) Received: from localhost (chuckr@localhost) by professor.eng.umd.edu (8.7.5/8.7.3) with SMTP id RAA07810; Sun, 8 Sep 1996 17:39:39 -0400 (EDT) X-Authentication-Warning: professor.eng.umd.edu: chuckr owned process doing -bs Date: Sun, 8 Sep 1996 17:39:39 -0400 (EDT) From: Chuck Robey X-Sender: chuckr@professor.eng.umd.edu To: Andreas Klemm cc: phk@critter.tfs.com, FreeBSD current Subject: Re: Make world In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 8 Sep 1996, Andreas Klemm wrote: > On Sun, 8 Sep 1996, Chuck Robey wrote: > > > Seems broke in lkm/wcd. Here's the error message: > > I think this happened, after Poul changed the struct atapi in > i386/isa/atapi.h (atapi.h 1.6 -> 1.7) and changed wcdattach, to > have one argument less ... > > I think a fix could be, to apply the following patch: but it's only > a guess ;-) So perhaps wait, if it's mission critical for you ;) The fix arrived in the next ctm update, Andreas. No need to fix it anymore, I guess. In fact, I shouldn't have reported it, because I hadn't checked that the update was ready to be applied. I was too anxious, sorry to have started this. > > RCS file: /local/CVS/src/sys/i386/isa/wcd.c,v > retrieving revision 1.38 > diff -u -r1.38 wcd.c > --- wcd.c 1996/09/06 23:32:40 1.38 > +++ wcd.c 1996/09/08 21:11:46 > @@ -1131,7 +1131,7 @@ > /* Probing controller ata->ctrlr, unit u. */ > if (ata->params[u] && ! ata->attached[u] && > wcdattach (ata, u, ata->params[u], > - ata->debug, ata->parent) >= 0) > + ata->debug) >= 0) > { > /* Drive found. */ > ata->attached[u] = 1; > > It compiles fine after that... > root{1101} /usr/src/lkm/wcd make > cc -pipe -O2 -nostdinc -I. -DWCD_MODULE -DKERNEL -DACTUALLY_LKM_NOT_KERNEL -I/usr/src/lkm/wcd/../../sys -W -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Winline -Wunused -Wpointer-arith > -c /usr/src/lkm/wcd/../../sys/i386/isa/wcd.c > /usr/src/lkm/wcd/../../sys/i386/isa/wcd.c:1114: warning: `rwcd_load' declared `static' but never defined > /usr/src/lkm/wcd/../../sys/i386/isa/wcd.c:1114: warning: `rwcd_unload' declared `static' but never defined > ld -r -o tmp.o wcd.o > symorder -c symb.tmp tmp.o > mv tmp.o wcd_mod.o > > -- > andreas@klemm.gtn.com /\/\___ Wiechers & Partner Datentechnik GmbH > Andreas Klemm ___/\/\/ Support Unix -- andreas.klemm@wup.de > pgp p-key http://www-swiss.ai.mit.edu/~bal/pks-toplev.html >>> powered by <<< > ftp://sunsite.unc.edu/pub/Linux/system/Printing/aps-491.tgz >>> FreeBSD <<< > > > ----------------------------+----------------------------------------------- Chuck Robey | Interests include any kind of voice or data chuckr@eng.umd.edu | communications topic, C programming, and Unix. 9120 Edmonston Ct #302 | Greenbelt, MD 20770 | I run Journey2 and n3lxx, both FreeBSD (301) 220-2114 | version 2.2 current -- and great FUN! ----------------------------+-----------------------------------------------