Date: Sun, 14 Dec 1997 15:29:46 -0500 (EST) From: Joe Traister <traister@mojozone.org> To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: kern/5294: net.inet.icmp.bmcastecho doesn't work Message-ID: <199712142029.PAA02369@manta.mojozone.org> Resent-Message-ID: <199712142050.MAA08934@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 5294
>Category: kern
>Synopsis: net.inet.icmp.bmcastecho doesn't work
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Dec 14 12:50:01 PST 1997
>Last-Modified:
>Originator: Joe Traister
>Organization:
None
>Release: FreeBSD 2.2.5-RELEASE i386
>Environment:
2.2.5-RELEASE
>Description:
The net.inet.icmp.bmcastecho sysctl variable doesn't stop the system
from replying to ICMP echo or timestamp requests sent to a broadcast
address.
>How-To-Repeat:
sysctl -w net.inet.icmp.bmcastecho=0
ping broadcast address of network and note that system still
replies.
>Fix:
--- ip_icmp.c.dist Sat Dec 13 23:23:36 1997
+++ ip_icmp.c Sun Dec 14 15:17:48 1997
@@ -377,8 +377,8 @@
case ICMP_ECHO:
if (!icmpbmcastecho
- && (m->m_flags & (M_MCAST | M_BCAST)) != 0
- && IN_MULTICAST(ntohl(ip->ip_dst.s_addr))) {
+ && ((m->m_flags & (M_MCAST | M_BCAST)) != 0
+ || IN_MULTICAST(ntohl(ip->ip_dst.s_addr)))) {
icmpstat.icps_bmcastecho++;
break;
}
@@ -387,8 +387,8 @@
case ICMP_TSTAMP:
if (!icmpbmcastecho
- && (m->m_flags & (M_MCAST | M_BCAST)) != 0
- && IN_MULTICAST(ntohl(ip->ip_dst.s_addr))) {
+ && ((m->m_flags & (M_MCAST | M_BCAST)) != 0
+ || IN_MULTICAST(ntohl(ip->ip_dst.s_addr)))) {
icmpstat.icps_bmcasttstamp++;
break;
}
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712142029.PAA02369>