From owner-svn-src-head@freebsd.org Sat Jan 14 02:40:02 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA01DCAF833; Sat, 14 Jan 2017 02:40:02 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 90A5D1830; Sat, 14 Jan 2017 02:40:01 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id SEFzcIwwMC8pGSEG0cIVkb; Fri, 13 Jan 2017 19:39:53 -0700 X-Authority-Analysis: v=2.2 cv=WoZbCZXv c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=IgFoBzBjUZAA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=rNrjpBi0COSOxzXsiRMA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 0DCD49F5; Fri, 13 Jan 2017 18:39:51 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v0E2doD2069898; Fri, 13 Jan 2017 18:39:50 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201701140239.v0E2doD2069898@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Conrad E. Meyer" cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312103 - head/tests/sys/vfs In-Reply-To: Message from "Conrad E. Meyer" of "Sat, 14 Jan 2017 01:03:20 +0000." <201701140103.v0E13K8b068874@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 13 Jan 2017 18:39:50 -0800 X-CMAE-Envelope: MS4wfDDEuTijvSGHAP2nOZnWRvwn04c9ETwG33S5TwAtXmsyhKvGbHEx8ipiHSpJHCIJ7ekE+XYt8pGbT+xs7dpiw7UHtnnTjrlmxLbpqj1K2menz6ZdN4EL 3hQIiTvICqueLfo23X7v347gIe3945MYzW2QqQB2h/bbxLNTUPY90x/bFNUc+PChmISZ4oSLl6kmOXvorpOD2wKzvkqOBNK7aJ5QOjfjyzM9eIJkeMo6O4xy k/dSF/959Yn/Dd0RyKvYDGLc+vQ10/LbI+IXmCc61LAZoahvb9w7kOnJUEGcJnHW X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2017 02:40:03 -0000 In message <201701140103.v0E13K8b068874@repo.freebsd.org>, "Conrad E. Meyer" wr ites: > Author: cem > Date: Sat Jan 14 01:03:20 2017 > New Revision: 312103 > URL: https://svnweb.freebsd.org/changeset/base/312103 > > Log: > Revert r310994 > > Don't implement some terrible hack on a test by test basis. The > framework fix is straightforward and can be chased up in the original > bug. > > Reviewed by: ngie ("be my guest") > > Modified: > head/tests/sys/vfs/lookup_cap_dotdot.c > > Modified: head/tests/sys/vfs/lookup_cap_dotdot.c > ============================================================================= > = > --- head/tests/sys/vfs/lookup_cap_dotdot.c Sat Jan 14 01:01:02 2017 > (r312102) > +++ head/tests/sys/vfs/lookup_cap_dotdot.c Sat Jan 14 01:03:20 2017 > (r312103) > @@ -31,27 +31,23 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > -#include > > #include > -#include > #include > #include > #include > > #include "freebsd_test_suite/macros.h" > > -static char *abspath; > -static int dirfd = -1; > - > -typedef void (*child_test_fn_t)(void); > +static int dirfd = -1; > +static char *abspath; > > static void > -touchat(int _dirfd, const char *name) > +touchat(int dirfd, const char *name) Buildworld is busted right here. It's probably best to leave the underbar here and in the ATF_REQIRE below. > { > int fd; > > - ATF_REQUIRE((fd = openat(_dirfd, name, O_CREAT | O_TRUNC | O_WRONLY, > + ATF_REQUIRE((fd = openat(dirfd, name, O_CREAT | O_TRUNC | O_WRONLY, Here too. > 0777)) >= 0); > ATF_REQUIRE(close(fd) == 0); > } -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.