Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Aug 2003 13:41:42 -0500 (CDT)
From:      Mike Silbersack <silby@silby.com>
To:        Sam Leffler <sam@errno.com>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/libkern arc4random.c
Message-ID:  <20030815133943.I1565@odysseus.silby.com>
In-Reply-To: <76344918.1060937662@melange.errno.com>
References:  <200308150634.h7F6Ylxw022089@repoman.freebsd.org> <76344918.1060937662@melange.errno.com>

next in thread | previous in thread | raw e-mail | index | archive | help


On Fri, 15 Aug 2003, Sam Leffler wrote:

> >   Lock down arc4random so it can be safely called w/o Giant.
> >
> >   Minor code reorganization was required, but the only functional
> >   change was that the first 1024 bytes of output are thrown out
> >   after each reseed, rather than just the initial seed.
>
> How did you validate the this change?  I strongly suggest that mods like
> this need review before commit.  Subtle problems can go unnoticed for a
> long time.
>
> 	Sam

I'm fairly confident that I did not add any bugs in this commit.  However,
I also have no way of knowing if arc4random was working correctly before
the commit either... How hard would it be to hook up the randomness
testing code you committed a few months back?  If the testing code is in
userland, perhaps we could export a /dev/arandom like openbsd does for
simpler testing.

Mike "Silby" Silbersack



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030815133943.I1565>