Date: Mon, 2 Sep 2019 00:37:59 +0000 (UTC) From: Ed Maste <emaste@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r351679 - stable/12/sys/dev/vnic Message-ID: <201909020037.x820bxbS099902@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: emaste Date: Mon Sep 2 00:37:59 2019 New Revision: 351679 URL: https://svnweb.freebsd.org/changeset/base/351679 Log: MFC r351603: vnic: avoid NULL deref in error case Reported by: Dr Silvio Cesare of InfoSect Sponsored by: The FreeBSD Foundation Modified: stable/12/sys/dev/vnic/thunder_bgx.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/vnic/thunder_bgx.c ============================================================================== --- stable/12/sys/dev/vnic/thunder_bgx.c Mon Sep 2 00:36:26 2019 (r351678) +++ stable/12/sys/dev/vnic/thunder_bgx.c Mon Sep 2 00:37:59 2019 (r351679) @@ -502,9 +502,8 @@ bgx_add_dmac_addr(uint64_t dmac, int node, int bgx_idx bgx_idx += node * MAX_BGX_PER_CN88XX; bgx = bgx_vnic[bgx_idx]; - if (!bgx) { - device_printf(bgx->dev, - "BGX%d not yet initialized, ignoring DMAC addition\n", + if (bgx == NULL) { + printf("BGX%d not yet initialized, ignoring DMAC addition\n", bgx_idx); return; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909020037.x820bxbS099902>