Date: Mon, 8 Apr 2013 11:19:28 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Jean-S?bastien P?dron <dumbbell@FreeBSD.org> Cc: Olivier Cochard-Labb? <olivier@cochard.me>, svn-src-head <svn-src-head@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r249041 - in head/sys/dev/drm2: . i915 Message-ID: <20130408081928.GB2930@kib.kiev.ua> In-Reply-To: <5161F3BA.8040001@FreeBSD.org> References: <201304030827.r338RZih051806@svn.freebsd.org> <CA%2Bq%2BTcr56QXUkNhS65nUQyfoAqgfRSp3RD5avL8LVATedeNPCA@mail.gmail.com> <5161ADD8.6090607@FreeBSD.org> <CA%2Bq%2BTcr7AGZxBXjdOKut=PPQ65DcJ3PPd-%2B7qXmc-fF1cOMu9A@mail.gmail.com> <20130407190509.GA2930@kib.kiev.ua> <5161F3BA.8040001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--f2QGlHpHGjS2mn6Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2013 at 12:31:22AM +0200, Jean-S?bastien P?dron wrote: > On 07.04.2013 21:05, Konstantin Belousov wrote: > > I suspect that the issue is with the drm2/i915/intel_dp.c. > > You might try to use shift to 7 instead of 8 for address in the > > intel_dp_aux_native_read/write, but I am not sure. >=20 > Based on your remark, I proposed the following patch to Olivier: > http://people.freebsd.org/~dumbbell/radeonkms/drm-i915-intel_iic.b.patch >=20 > And it worked for him! >=20 > If I understand correctly, this "aux channel" emulates a I2C bus. The > patch right-shifts back the slave address (in drm_dp_iic_helper.c). This > address is then used in intel_dp_i2c_aux_ch() (intel_dp.c). >=20 > If you agree, I can commit it. I see no reason to disagree. Please commit. As a side note, it is a miracle that DP connector KMS works at all. I had no DP hardware when I did the port, and Linux driver got a huge amount of bugfixes and churn in this area, which changes were only partially imported. I think that there is a complete rework of the modesetting sequence for Linux, either committed or going to be committed, motivated by the non-conformance of the DP and eDP handling. --f2QGlHpHGjS2mn6Y Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRYn2PAAoJEJDCuSvBvK1BwAkP/1KRAxsRDZdN+/njSSu1KI5h MPzEsY6+yzWfMIkEHX0YDbUdF3tEzdSYhPTiAbjHpZts9SqBRbPR2y9MbZAaNZpJ hG8HcJ7+gAvwaPuileztv6i17Yj+LWekkZjLoZ8k2zDugD1ipdYgW+pYvzT4VTKx LomNNR5cOezUWbr8ChaA866Td6WIDpfIrq1Fho4WmJHoDUyrIJ/6Q8kfSmXn7TZX DbZXCKVIcU71/T3krrOjGUqXGMb2axUjY5ZA0CK5L62lzQ69NQPtGEhLAACWefvN l1fTTXcS46aL2uk904dE4nsJ8hYFl8wsRHCvDvVpy4Lk6DYhEZdJ8ro+unmhhbEk 7t86o+qeINzF97VBVg4+3gWszCkxV5B0YyfKOaHw8DCaqEWrpD8FO4kDplN1LLO2 PWhAqAqFNUp+HYNVmTzOwd7wCmLbrRqt49ZTO55JDoOPlqUwutgoOUH6w4FHuGUa jDKFbf96vlhihvMc6hdTyCX758NZ3uCTKUY5l7tgAYjTsBx8ZUiSqPFm+MjMsPhX p4QfBZ9FSumUVb/uShOeNjPm3UEDox8WSHIBVs8/BTFus3Kahu5/PIy7ntw4YXYd xmGyt9u09JIsfHWhapIPv0Mf5GP5zn2+5Ib6Vg0mHDCXjqDfAknskA3zo8hIbV0O pZHkQmQVDwPRtnrHUduM =ilQO -----END PGP SIGNATURE----- --f2QGlHpHGjS2mn6Y--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130408081928.GB2930>