From owner-svn-src-all@FreeBSD.ORG Mon Apr 8 08:19:43 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A6E2F379; Mon, 8 Apr 2013 08:19:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4B0949C5; Mon, 8 Apr 2013 08:19:43 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.6/8.14.6) with ESMTP id r388JSAB068202; Mon, 8 Apr 2013 11:19:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.2 kib.kiev.ua r388JSAB068202 Received: (from kostik@localhost) by tom.home (8.14.6/8.14.6/Submit) id r388JStj068201; Mon, 8 Apr 2013 11:19:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 8 Apr 2013 11:19:28 +0300 From: Konstantin Belousov To: Jean-S?bastien P?dron Subject: Re: svn commit: r249041 - in head/sys/dev/drm2: . i915 Message-ID: <20130408081928.GB2930@kib.kiev.ua> References: <201304030827.r338RZih051806@svn.freebsd.org> <5161ADD8.6090607@FreeBSD.org> <20130407190509.GA2930@kib.kiev.ua> <5161F3BA.8040001@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f2QGlHpHGjS2mn6Y" Content-Disposition: inline In-Reply-To: <5161F3BA.8040001@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: Olivier Cochard-Labb? , svn-src-head , svn-src-all , src-committers X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2013 08:19:43 -0000 --f2QGlHpHGjS2mn6Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2013 at 12:31:22AM +0200, Jean-S?bastien P?dron wrote: > On 07.04.2013 21:05, Konstantin Belousov wrote: > > I suspect that the issue is with the drm2/i915/intel_dp.c. > > You might try to use shift to 7 instead of 8 for address in the > > intel_dp_aux_native_read/write, but I am not sure. >=20 > Based on your remark, I proposed the following patch to Olivier: > http://people.freebsd.org/~dumbbell/radeonkms/drm-i915-intel_iic.b.patch >=20 > And it worked for him! >=20 > If I understand correctly, this "aux channel" emulates a I2C bus. The > patch right-shifts back the slave address (in drm_dp_iic_helper.c). This > address is then used in intel_dp_i2c_aux_ch() (intel_dp.c). >=20 > If you agree, I can commit it. I see no reason to disagree. Please commit. As a side note, it is a miracle that DP connector KMS works at all. I had no DP hardware when I did the port, and Linux driver got a huge amount of bugfixes and churn in this area, which changes were only partially imported. I think that there is a complete rework of the modesetting sequence for Linux, either committed or going to be committed, motivated by the non-conformance of the DP and eDP handling. --f2QGlHpHGjS2mn6Y Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRYn2PAAoJEJDCuSvBvK1BwAkP/1KRAxsRDZdN+/njSSu1KI5h MPzEsY6+yzWfMIkEHX0YDbUdF3tEzdSYhPTiAbjHpZts9SqBRbPR2y9MbZAaNZpJ hG8HcJ7+gAvwaPuileztv6i17Yj+LWekkZjLoZ8k2zDugD1ipdYgW+pYvzT4VTKx LomNNR5cOezUWbr8ChaA866Td6WIDpfIrq1Fho4WmJHoDUyrIJ/6Q8kfSmXn7TZX DbZXCKVIcU71/T3krrOjGUqXGMb2axUjY5ZA0CK5L62lzQ69NQPtGEhLAACWefvN l1fTTXcS46aL2uk904dE4nsJ8hYFl8wsRHCvDvVpy4Lk6DYhEZdJ8ro+unmhhbEk 7t86o+qeINzF97VBVg4+3gWszCkxV5B0YyfKOaHw8DCaqEWrpD8FO4kDplN1LLO2 PWhAqAqFNUp+HYNVmTzOwd7wCmLbrRqt49ZTO55JDoOPlqUwutgoOUH6w4FHuGUa jDKFbf96vlhihvMc6hdTyCX758NZ3uCTKUY5l7tgAYjTsBx8ZUiSqPFm+MjMsPhX p4QfBZ9FSumUVb/uShOeNjPm3UEDox8WSHIBVs8/BTFus3Kahu5/PIy7ntw4YXYd xmGyt9u09JIsfHWhapIPv0Mf5GP5zn2+5Ib6Vg0mHDCXjqDfAknskA3zo8hIbV0O pZHkQmQVDwPRtnrHUduM =ilQO -----END PGP SIGNATURE----- --f2QGlHpHGjS2mn6Y--