Date: Fri, 22 Oct 2004 19:03:04 -0500 (CDT) From: "Douglas K. Rand" <rand@meridian-enviro.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/73020: qpage runs words together Message-ID: <200410230003.i9N034ga099358@delta.meridian-enviro.com> Resent-Message-ID: <200410230010.i9N0ANvX011371@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 73020
>Category: ports
>Synopsis: qpage runs words together
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Oct 23 00:10:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Douglas K. Rand
>Release: FreeBSD 4.10-RELEASE-p2 i386
>Organization:
Meridian Environmental Technology, Inc.
>Environment:
System: FreeBSD delta.meridian-enviro.com 4.10-RELEASE-p2 FreeBSD 4.10-RELEASE-p2 #21: Mon Aug 30 21:55:51 CDT 2004 rand@delta.meridian-enviro.com:/usr/obj/usr/src/sys/DELTA i386
>Description:
The qpage port will run words together in long pages. The problem
is in msgcpy in util.c, where the breaks don't preserve word
boundries.
>How-To-Repeat:
qpage -p USER -f USER "this is a test of a message where two words will have the white space between them removed"
results in this page being delivered:
USER: this is a test of a message where two words will have the whitespace between them removed
(Notice that "white space" became "whitespace", and no I didn't plan my test
case that carefully. :))
>Fix:
Add this patch file to the port. I've also submitted it to the
author of qpage.
--- /tmp/ports/a/Agena/usr/ports/comms/qpage/work/qpage-3.3/util.c-orig Fri Oct 22 18:57:00 2004
+++ /tmp/ports/a/Agena/usr/ports/comms/qpage/work/qpage-3.3/util.c Fri Oct 22 18:57:04 2004
@@ -537,7 +537,7 @@
** Now make sure we didn't chop a word in the middle.
*/
if (*src && end) {
- *end++ = '\0';
+ *++end = '\0';
src = start;
}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410230003.i9N034ga099358>