From owner-cvs-src  Sat Feb 15 15:51:47 2003
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 175E637B405; Sat, 15 Feb 2003 15:51:45 -0800 (PST)
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CBCDB43F3F; Sat, 15 Feb 2003 15:51:43 -0800 (PST)
	(envelope-from ache@pobrecita.freebsd.ru)
Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.12.7/8.12.7) with ESMTP id h1FNpgEJ072617;
	Sun, 16 Feb 2003 02:51:42 +0300 (MSK)
	(envelope-from ache@pobrecita.freebsd.ru)
Received: (from ache@localhost)
	by pobrecita.freebsd.ru (8.12.7/8.12.6/Submit) id h1FNpgIB072616;
	Sun, 16 Feb 2003 02:51:42 +0300 (MSK)
	(envelope-from ache)
Date: Sun, 16 Feb 2003 02:51:42 +0300
From: "Andrey A. Chernov" <ache@nagual.pp.ru>
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libpam/modules/pam_opieaccess pam_opieaccess.c
Message-ID: <20030215235142.GH72156@nagual.pp.ru>
References: <200302152326.h1FNQnAr027546@repoman.freebsd.org> <20030215233943.GC72156@nagual.pp.ru> <20030215234406.GD72156@nagual.pp.ru> <xzplm0hm7h9.fsf@flood.ping.uio.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xzplm0hm7h9.fsf@flood.ping.uio.no>
User-Agent: Mutt/1.5.1i
Sender: owner-cvs-src@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-src.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-src>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-src>
X-Loop: FreeBSD.ORG

On Sun, Feb 16, 2003 at 00:47:46 +0100, Dag-Erling Smorgrav wrote:
> "Andrey A. Chernov" <ache@nagual.pp.ru> writes:
> > Look at this code from accessfile.c:
> >  if (!host[0])
> >     /* Local login, okay */
> >     return (1);
> 
> That is an *empty* host name, not a NULL one.  Go bother someone else.

Empty host name means localhost, i.e. occurse for localhost case. Your 
explicit addition of "localhost" string break this code, since "" != 
"localhost". After adding "localhost" breakage you forced to change 
/etc/opieaccess because default "" case for localhost not works anymore.

Correct solution will be:
if (host == NULL)
	host = "";

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message