Date: Mon, 20 Nov 2017 11:56:43 -0500 From: Ed Maste <emaste@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325988 - head/sys/libkern Message-ID: <CAPyFy2B98iviaAm9wuCiE%2B32UoVDoCKCgHaa%2BO4nwbexwSUPaw@mail.gmail.com> In-Reply-To: <20171119173822.J974@besplex.bde.org> References: <201711190031.vAJ0VE9m016670@repo.freebsd.org> <20171119173822.J974@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Bruce, notes on a few of the points you raised (I'll look at others later): On 19 November 2017 at 04:07, Bruce Evans <brde@optusnet.com.au> wrote: > > The vendor version is in libc/string. It has been ANSIfied, but the > libkern version has large churning to "optimize" it. It is the libkern > version that should have been optimized, since bcmp is unimportant in > the kernel and in most applications, but applications have a wider range > so a few might benefit from optimizing it. I presume you meant "it is the _libc_ version that should have been optimized", but could also read this as a distinction between optimized and scare-quotes "optimized." > bcmp is actually optimized > in the kernel in support.[sS] for all arches except powerpc and riscv, > so optimizing the kernel MI version of it is especially unimportant. > In libc where MD optimizations are more important, they are also not > done for arm, arm64 and sparc64. This could make a nice small project for someone to take on. > - libc version copyright comment not marked for indent protection using > "/*-" (this has been subverted to have another meaning which I forget). I don't believe there's another meaning. IIRC imp@ has pointed out that it means precisely what you've mentioned above. >> Modified: head/sys/libkern/cmpdi2.c >> Modified: head/sys/libkern/divdi3.c >> Modified: head/sys/libkern/lshrdi3.c > > Like ashrdi3.c (not ANSIfied in libc/quad). Ok, I will update libc/quad to match. > The above declaration was already correctly ANSIfied in libc/gmon. This > unimproves the style by keeping the comment misplaced at the right of the > code where it is a larger style bug than before -- not the line is too long. > ANSIfication in libc/gmon put it on a separate line. Will update the comment along with other mcount tidying. >> Modified: head/sys/libkern/strcmp.c > > The vendor version is in libc/string. It has been ANSIfied, but the commit > that did that also made another style fix. This change catches up with half > of the older change. Will update.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2B98iviaAm9wuCiE%2B32UoVDoCKCgHaa%2BO4nwbexwSUPaw>