Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Nov 1999 14:13:46 -0800 (PST)
From:      Sean Eric Fagan <sef@kithrup.com>
To:        current@freebsd.org
Subject:   Re: PATCH for testing
Message-ID:  <199911152213.OAA20176@kithrup.com>
In-Reply-To: <22209.942703421.kithrup.freebsd.current@critter.freebsd.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
In article <22209.942703421.kithrup.freebsd.current@critter.freebsd.dk> you write:
>The p_args.patch patch implements a cache of the commandline arguments
>in the process structure and makes ps(1) pick it up from there with
>sysctl rather than by groping around in the target process memory.

I don't think this should go in at all.

It increases the size of the proc structure (thereby affecting _all_
processes) gratuitously.  While I'm generally in favour of having the process
arguments kept around, the "BSD way" has been to only examine them in user
memory, despite that being unreliable and just annoying.

The benefits are fairly minimal, and I don't believe justify the cost
incurred.



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199911152213.OAA20176>