Date: Fri, 4 Apr 2014 20:48:08 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Julio Merino <jmmv@freebsd.org> Cc: x11@freebsd.org Subject: Re: xorg-server fails to build as non-root Message-ID: <20140404184808.GE97416@ivaldir.etoilebsd.net> In-Reply-To: <20140404183304.GA85500@mastodon.meroh.net> References: <20140404183304.GA85500@mastodon.meroh.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--idY8LE8SD6/8DnRI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Apr 04, 2014 at 02:33:04PM -0400, Julio Merino wrote:
> Hello,
>=20
> The staging phase of xorg-server fails when run as non-root because the
> package installation tries to make the Xorg binary setuid root.
>=20
> The patch below fixes it. I'm not sure if there would be a better and
> preferrable alternative.
>=20
> Thoughts?
>=20
> Thanks!
>=20
>=20
> Index: Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- Makefile (revision 349914)
> +++ Makefile (working copy)
> @@ -109,6 +109,11 @@
> .if ${PORT_OPTIONS:MSUID}
> CONFIGURE_ARGS+=3D--enable-install-setuid=3Dyes
> PLIST_SUB+=3D SUID=3D""
> +
> +# The configure script tries to detect if we can install Xorg as root so=
that
> +# the binary can be made setuid later. If we are not root, this obvious=
ly
> +# fails at one point or another.
> +NEED_ROOT=3D yes
> .else
> CONFIGURE_ARGS+=3D--enable-install-setuid=3Dno
> PLIST_SUB+=3D SUID=3D"@comment "
> _______________________________________________
> freebsd-x11@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-x11
> To unsubscribe, send any mail to "freebsd-x11-unsubscribe@freebsd.org"
I will come with a better patch not adding NEED_ROOT
NEED_ROOT was a mistake I should not have done ;)
regards,
Bapt
--idY8LE8SD6/8DnRI
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iEYEARECAAYFAlM+/mgACgkQ8kTtMUmk6EzEWACeK0qYXb3hE6ZG/91KyLp86z+L
IO8AnR/rEA++aeJ07sDE5B3EyvVtsBbk
=DuXJ
-----END PGP SIGNATURE-----
--idY8LE8SD6/8DnRI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140404184808.GE97416>