Date: Mon, 25 Oct 2004 16:40:25 GMT From: Ken Smith <kensmith@cse.Buffalo.EDU> To: freebsd-sparc64@FreeBSD.org Subject: Re: sparc64/72962: [sysinstall] Sysinstall panics on sparc64 if /dev/cd0 present Message-ID: <200410251640.i9PGePU6023029@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR sparc64/72962; it has been noted by GNATS.
From: Ken Smith <kensmith@cse.Buffalo.EDU>
To: Andrew Belashov <bel@orel.ru>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: sparc64/72962: [sysinstall] Sysinstall panics on sparc64 if /dev/cd0 present
Date: Mon, 25 Oct 2004 12:35:05 -0400
On Thu, Oct 21, 2004 at 04:36:59PM +0400, Andrew Belashov wrote:
> >Fix:
>
> It is necessary to fix libdisk(3).
>
> --- libdisk.patch begins here ---
> --- lib/libdisk/open_disk.c.orig Tue Oct 12 16:02:58 2004
> +++ lib/libdisk/open_disk.c Thu Oct 21 16:19:40 2004
> @@ -267,6 +267,8 @@ Int_Open_Disk(const char *name, char *co
> if (platform == p_sparc64 && d->chunks->part->part == NULL) {
> hd = d->bios_hd;
> sc = d->bios_sect;
> + if ((hd * sc) == 0)
> + return (NULL);
> o = d->chunks->size / (hd * sc);
> o *= (hd * sc);
> o -= 2 * hd * sc;
> --- libdisk.patch ends here ---
Just letting you know... I'm not ignoring this, I've started to work
on it. I tested this patch and then passed it off to someone for review.
His reaction was that this patch shouldn't be necessary, sysinstall never
should have gotten this far. It should have recognized the device more
clearly as a CDROM and not used Int_Open_Disk() as a consequence. I'm
guessing that this behavior is also why we're seeing CDROM's offered as
*targets* for installation in sysinstall for some configurations.
So at the moment I'm looking through more of sysinstall to understand
a bit better how it's supposed to handle CDROM's. :-)
--
Ken Smith
- From there to here, from here to | kensmith@cse.buffalo.edu
there, funny things are everywhere. |
- Theodore Geisel |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410251640.i9PGePU6023029>