Date: Wed, 29 Jun 2016 16:33:52 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r417364 - head/Mk/Scripts Message-ID: <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org> In-Reply-To: <201606231131.u5NBVFur021580@repo.freebsd.org> References: <201606231131.u5NBVFur021580@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FKlFuQlBaFSkbhqKvCNEm7G2MRlxu1k6E Content-Type: multipart/mixed; boundary="jTrlsHJQ2CEKvpnXTmdCI4DXcIJ9vLO9C" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org> Subject: Re: svn commit: r417364 - head/Mk/Scripts References: <201606231131.u5NBVFur021580@repo.freebsd.org> In-Reply-To: <201606231131.u5NBVFur021580@repo.freebsd.org> --jTrlsHJQ2CEKvpnXTmdCI4DXcIJ9vLO9C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 6/23/2016 4:31 AM, Mathieu Arnold wrote: > Author: mat > Date: Thu Jun 23 11:31:15 2016 > New Revision: 417364 > URL: https://svnweb.freebsd.org/changeset/ports/417364 >=20 > Log: > Extend the symlink checks to warn on absolute targets. > =20 > Sponsored by: Absolight > Differential Revision: https://reviews.freebsd.org/D6930 Why? This seems like noise. =3D=3D=3D=3D> Running Q/A tests (stage-qa) Warning: Bad symlink '/usr/local/share/poudriere/MANIFESTS' pointing to an absolute pathname '/usr/local/share/freebsd/MANIFESTS' Comes from: ${LN} -fs ${LOCALBASE}/share/freebsd/MANIFESTS \ ${STAGEDIR}${DATADIR}/MANIFESTS Now carefully note that DATADIR is based on PREFIX. It's not safe to assume PREFIX =3D=3D LOCALBASE. So I cannot just create a relative symlink from DATADIR/MANIFESTS to =2E./../freebsd/MANIFESTS, because that assumes and forces that PREFIX =3D= =3D LOCALBASE. By the way, I noticed this had been out for review. Yes I missed that. Still, I was surprised by this. --=20 Regards, Bryan Drewery --jTrlsHJQ2CEKvpnXTmdCI4DXcIJ9vLO9C-- --FKlFuQlBaFSkbhqKvCNEm7G2MRlxu1k6E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXdFrgAAoJEDXXcbtuRpfPefsH/0jf0tSf23zwB9Pu0xSx4yzk DVO+PpAEygX8viaFEPJx6uJxippLV5rIG3JK8EFcP0AAufYRpEITC/w3SQ5+F28J 1GEZtZ3/nOAFVvwle0OH14poBlbq7FJ3FE/HpA7tsfisOeA6JdaqlsUnLB6NlwP2 IYFURMnubyCHKq6uNYclY2j5Gu/94c5oPq7s6u/4TpXXyHa/aNXAdSgcsxdZDudF mIP2kEwGLUKNnUrtigIWjUCccaLfCVk56F27l8upn7oMadp50kAErs4HuvgNlhTa uT05uRKo/XR2QRIsegdpUp/hNGzOhmmXrhAAzxFaeR5W+Fnn2Cj3AmQmN58A/Jk= =Nj8+ -----END PGP SIGNATURE----- --FKlFuQlBaFSkbhqKvCNEm7G2MRlxu1k6E--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?075ef3c9-89f1-8e95-c86a-bf00831c373e>