From owner-svn-src-all@FreeBSD.ORG Thu Jan 19 16:46:27 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 595AC106566C; Thu, 19 Jan 2012 16:46:27 +0000 (UTC) (envelope-from gleb.kurtsou@gmail.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3E9068FC1C; Thu, 19 Jan 2012 16:46:25 +0000 (UTC) Received: by lahe6 with SMTP id e6so105661lah.13 for ; Thu, 19 Jan 2012 08:46:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=5ZwNEFupwgpLYPPMp4F3cfoue8+a0wcdRuq/APYHSmk=; b=CHHxlAQWNzNgOzMzEQPMHMsX8tmPgJMaJNQqqplzoPJQsXBuJex65x7ncy9YEWaedB eCpQzOJ2gRkXU4eLb58sHMshFQWzz1b64xZnrN+dKl3Ank3V2uCggEtSrBrdZg4B6XCL +kka0IYG7zK7Wy4orwPAZ8QddnNkbSb/tZJkI= Received: by 10.152.147.1 with SMTP id tg1mr10906lab.22.1326991584953; Thu, 19 Jan 2012 08:46:24 -0800 (PST) Received: from localhost ([78.157.92.5]) by mx.google.com with ESMTPS id lz18sm16036773lab.17.2012.01.19.08.46.23 (version=SSLv3 cipher=OTHER); Thu, 19 Jan 2012 08:46:24 -0800 (PST) Date: Thu, 19 Jan 2012 18:46:27 +0200 From: Gleb Kurtsou To: Gleb Smirnoff Message-ID: <20120119164627.GA42205@reks> References: <201201160953.q0G9rPp8026625@svn.freebsd.org> <20120119143837.GA28308@reks> <20120119145132.GZ12760@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20120119145132.GZ12760@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r230207 - in head/sys: netinet sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2012 16:46:27 -0000 On (19/01/2012 18:51), Gleb Smirnoff wrote: > On Thu, Jan 19, 2012 at 04:38:38PM +0200, Gleb Kurtsou wrote: > G> On (16/01/2012 09:53), Gleb Smirnoff wrote: > G> > Author: glebius > G> > Date: Mon Jan 16 09:53:24 2012 > G> > New Revision: 230207 > G> > URL: http://svn.freebsd.org/changeset/base/230207 > G> > > G> > Log: > G> > Drop support for SIOCSIFADDR, SIOCSIFNETMASK, SIOCSIFBRDADDR, SIOCSIFDSTADDR > G> > ioctl commands. > G> > G> What was the reason for dropping them? "80-ish ioctl" doesn't justify > G> reducing compatibility with other unix-like OS'es (namely linux). > > The reason is to get code more readable and thus maintainable. You can compare > in_control() + in_addprefix() in the stable/9 with what we have in head now. > Which one would you prefer to hack on? Your point is valid and I'm all for it. > I wouldn't claim compatibility for the commands that didn't work very well. > I won't also name Linux, since these commands predate the Linux itself. I meant that SIOCSIFADDR is default (if not the only) way to set interface address on linux. > Do you use them? Or do you know software that use them? I do and I've seen other examples of using SIOCSIF*ADDR with BSD specific tweaks. Although I must admit that nowadays the most common way of configuring interface is to call /sbin/ifconfig. It's not a big deal for me, I have no problem with replacing them on FreeBSD. FreeBSD is not even officially supported platform for the product and I build/test on FreeBSD solely for the purpose of avoiding linuxisms and platform specific behaviour. Let's hope it won't break for somebody else :) Thanks, Gleb. > > -- > Totus tuus, Glebius.