Date: Thu, 4 Aug 2016 05:51:16 +0000 (UTC) From: John Marino <marino@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r419596 - head/japanese/libtomoe-gtk Message-ID: <201608040551.u745pG5j069776@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: marino Date: Thu Aug 4 05:51:16 2016 New Revision: 419596 URL: https://svnweb.freebsd.org/changeset/ports/419596 Log: japanese/libtomoe-gtk: fix illegal placement of USES USES must be defined before any inclusions like <options> or <pre>, otherwise they can't get registered as run dependencies. The presence of USES=python after <pre> was trying to build+run dependency on python conditionally based on the presence of an installed file. Since the condition can't be moved up due to the LOCALBASE variable, I've moved python up but changed it to USES+=python:build so that python will never be registered as a run dependency, but it will be available if required for building. The alternative is register python as a run dependency in every case because the port can't stay how it is. I picked the more conservative option I think. Approved by: just-fix-it Modified: head/japanese/libtomoe-gtk/Makefile Modified: head/japanese/libtomoe-gtk/Makefile ============================================================================== --- head/japanese/libtomoe-gtk/Makefile Thu Aug 4 05:12:10 2016 (r419595) +++ head/japanese/libtomoe-gtk/Makefile Thu Aug 4 05:51:16 2016 (r419596) @@ -3,7 +3,7 @@ PORTNAME= libtomoe-gtk PORTVERSION= 0.6.0 -PORTREVISION= 9 +PORTREVISION= 10 CATEGORIES= japanese MASTER_SITES= SF/tomoe/tomoe-gtk/tomoe-gtk-${PORTVERSION} DISTNAME= tomoe-gtk-${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX} @@ -14,7 +14,7 @@ COMMENT= TOMOE GTK+ library LIB_DEPENDS= libtomoe.so:japanese/tomoe GNU_CONFIGURE= yes -USES= gmake libtool pathfix pkgconfig +USES= gmake libtool pathfix pkgconfig python:build USE_GNOME= gtk20 USE_LDCONFIG= yes @@ -31,7 +31,6 @@ PLIST_SUB+= GUCHARMAP="@comment " #.endif .if exists(${LOCALBASE}/libdata/pkgconfig/pytomoe.pc) -USES+= python CONFIGURE_ENV+= PYTHON_VERSION=${PYTHON_VERSION:S;python;;} \ pyexecdir=${PYTHON_SITELIBDIR} PLIST_SUB+= PYTHON=""
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608040551.u745pG5j069776>