Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Mar 2021 17:28:49 +0200
From:      Gunther Nikl <gnikl@justmail.de>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r563988 - in head: . www www/opera www/opera-linuxplugins
Message-ID:  <20210328172849.00001b53@justmail.de>
In-Reply-To: <202102040439.1144dLYE014262@repo.freebsd.org>
References:  <202102040439.1144dLYE014262@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Am 04.02.2021 um 04:39 Baptiste Daroussin schrieb:

> Author: bapt
> Date: Thu Feb  4 04:39:20 2021
> New Revision: 563988
> URL: https://svnweb.freebsd.org/changeset/ports/563988
> 
> Log:
>   In preparation for the removal of gstreamer 0.x
>   
>   Remove opera web browser, it hasn't received an update since 2013
> and carries many security concerns.
>   
>   It remained in the ports tree because of the very niche usage, but
> it is now time to retire.
>   
>   Discussed with:	ak (maintainer)

I noticed that commit only a few days ago. I knew that browser for a
long time, but I discovered it for me only when it was already an
almost dead horse. The removal saddens me, but it was probably
inevitable.

> Deleted:
>   head/www/opera/
>   head/www/opera-linuxplugins/

What about linux-opera? 

Now the reason to create a PR about this port and base libz is gone.
FWIW, there is a symbol conflict between the FreeBSD opera binaries and
libz. The base libz exports several private symbols because the build
does not enable its HIDDEN attribute support. Since the FreeBSD opera
binaries export the same symbols there is an ABI conflict. The problem
arose with mesa 18 when it got zlib compressed shader cache. However,
it seems the FreeBSD opera was no used that much anymore since nobody
noticed that probkem. nterestingly, the Linux opera binaries do not
export those symbols.
I am including a small test program demonstrating the erroneous
behaviour.

Regards,
Gunther

> Modified:
>   head/MOVED
>   head/www/Makefile
> 
> Modified: head/MOVED
> ==============================================================================
> --- head/MOVED	Thu Feb  4 01:53:06 2021	(r563987)
> +++ head/MOVED	Thu Feb  4 04:39:20 2021	(r563988)
> @@ -16063,3 +16063,5 @@
> www/p5-RT-Extension-RepeatTicket@rt44|www/p5-RT-Extens
> www/p5-RTx-Calendar@rt42||2021-02-02|Removed, currently only
> supported with www/rt44
> www/p5-RTx-Calendar@rt44|www/p5-RTx-Calendar|2021-02-02|Unflavor,
> currently only supported with www/rt44
> www/rt42|www/rt44|2021-02-02|Has expired: Upstream support is ending;
> please migrate to RT-5.0 (www/rt50)
> +www/opera||2021-02-04|Abandonware since 2013
> +www/opera-linuxplugins||2021-02-04|Depends on opera browser
> 
> Modified: head/www/Makefile
> ==============================================================================
> --- head/www/Makefile	Thu Feb  4 01:53:06 2021	(r563987)
> +++ head/www/Makefile	Thu Feb  4 04:39:20 2021	(r563988)
> @@ -476,8 +476,6 @@
>      SUBDIR += onionbalance
>      SUBDIR += onionshare
>      SUBDIR += opencart
> -    SUBDIR += opera
> -    SUBDIR += opera-linuxplugins
>      SUBDIR += orangehrm
>      SUBDIR += osrm-backend
>      SUBDIR += osticket

-- cut --
//cc -g -O0 zlib-error.c -o zlib-error.exe -lz
#include <stdio.h>

/* functions called if shared zlib was NOT build with HIDDEN attribute!
*/
void _tr_init() { fprintf (stderr, "BAD:_tr_init!\n"); }
void _tr_tally() { fprintf (stderr, "BAD:_tr_tally!\n"); }
void _tr_align() { fprintf (stderr, "BAD:_tr_align!\n"); }
void _tr_stored_block() { fprintf (stderr, "BAD:_tr_stored_block!\n"); }
void _tr_flush_block() { fprintf (stderr, "BAD:_tr_flush_block!\n"); }

#include "zlib.h"

int main(void)
{
  unsigned char out[ 128 ];
  z_stream strm;

  strm.zalloc = Z_NULL;
  strm.zfree = Z_NULL;
  strm.opaque = Z_NULL;
  strm.next_in = (Bytef *) "hello world";
  strm.avail_in = 11;
  deflateInit(&strm, Z_DEFAULT_COMPRESSION);

  strm.avail_out = 128;
  strm.next_out = out;
  deflate(&strm, Z_FINISH);

  (void)deflateEnd(&strm);

  return 0;
}
-- cut --



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210328172849.00001b53>