From owner-freebsd-current@FreeBSD.ORG Wed Dec 3 12:05:44 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F29816A4CE for ; Wed, 3 Dec 2003 12:05:44 -0800 (PST) Received: from mail7.speakeasy.net (mail7.speakeasy.net [216.254.0.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id D872843FDF for ; Wed, 3 Dec 2003 12:05:42 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 27258 invoked from network); 3 Dec 2003 20:05:42 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 3 Dec 2003 20:05:42 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id hB3K5WFn010296; Wed, 3 Dec 2003 15:05:33 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Wed, 03 Dec 2003 15:05:38 -0500 (EST) From: John Baldwin To: Igor Sysoev X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: freebsd-current@FreeBSD.org Subject: Re: A page fault in subr_turnstile.c:propogate_priority() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2003 20:05:44 -0000 On 03-Dec-2003 Igor Sysoev wrote: > On Wed, 3 Dec 2003, John Baldwin wrote: > >> On 03-Dec-2003 Igor Sysoev wrote: >> > On Wed, 3 Dec 2003, John Baldwin wrote: >> > >> >> >> >> On 03-Dec-2003 Igor Sysoev wrote: >> >> > On Wed, 3 Dec 2003, John Baldwin wrote: >> >> > >> >> >> On 03-Dec-2003 Brian F. Feldman wrote: >> >> >> > Igor Sysoev wrote: >> >> >> >> I'd cvsup'ed 5.1-CURRENT from 2003.11.04.02.02.00 up to >> >> >> >> 2003.11.28.00.00.00 with the turnstile support and it can still >> >> >> >> causes sometimes a page fault in propogate_priority(). >> >> >> >> I have core dump and can send debug output. > >> Both faults are a trap 12 page fault with a faulting va of 0xe5 >> because td1 is NULL in priority propagation. Try this change to >> get a better cashdump that can be analyzed: >> >> Index: subr_turnstile.c >> =================================================================== >> RCS file: /usr/cvs/src/sys/kern/subr_turnstile.c,v >> retrieving revision 1.134 >> diff -u -r1.134 subr_turnstile.c >> --- subr_turnstile.c 12 Nov 2003 23:48:42 -0000 1.134 >> +++ subr_turnstile.c 3 Dec 2003 17:48:02 -0000 >> @@ -254,6 +254,7 @@ >> } >> >> td1 = TAILQ_PREV(td, threadqueue, td_lockq); >> + MPASS(td1 != NULL); >> if (td1->td_priority <= pri) { >> mtx_unlock_spin(&tc->tc_lock); >> continue; >> >> Then print 'td' and '*ts' in gdb from the priority_propagation() >> frame and mail the output. > > With a patch from http://www.FreeBSD.org/~jhb/patches/turnstile.patch > I can not even rebuild kernel. Can I add MPASS to sources from > 2003.11.28.00.00.00 ? Sure. I've reproduced a panic locally with turnstile.patch. I can't get my box to get a crash dump though. The ata crash dump code seems to have panicd. :( Just revert turnstile.patch for now. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/