Date: Wed, 6 Feb 2019 11:29:32 -0600 From: Will Andrews <will@firepipe.net> To: Bruce Evans <brde@optusnet.com.au> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325728 - head/lib/libkvm Message-ID: <CADBaqmjZsB9iQQgLg%2B_XpzyEoBTgDNAD345ks0FgSi5ROmhM7w@mail.gmail.com> In-Reply-To: <20190206024025.X3175@besplex.bde.org> References: <201711112330.vABNUwXC077395@repo.freebsd.org> <CAPyFy2BwNGHkMjj2rG5N5S=7E8N=9jfAUBki1L8eCY3kMeM8fw@mail.gmail.com> <20190205202145.A1080@besplex.bde.org> <CAPyFy2C%2BZ0aOGUBbgpLZ8sJbaN2YhEbR1YkV9Ya7POTSsbLqGQ@mail.gmail.com> <20190206024025.X3175@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 5, 2019 at 10:25 AM Bruce Evans <brde@optusnet.com.au> wrote: > Signed kp_offset seems wrong. Apart from it not reaching the top of 64- > bit address spaces, adding unsigned kp_len to it gives an unsigned type. > It's appropriate, because in this context, we return page information including addresses that would be valid pointer references, but are not included in the core file. Minidumps omit large numbers of physical pages, so calls to kvm_walk_pages() will generate large numbers of kvm_page instances that have an offset of -1. --Will.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADBaqmjZsB9iQQgLg%2B_XpzyEoBTgDNAD345ks0FgSi5ROmhM7w>