Date: Thu, 21 Jul 2016 22:56:17 -0600 From: Adam Weinberger <adamw@adamw.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Kris Moore <kmoore@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r418889 - in head/deskutils: . copyq Message-ID: <91496634-0037-4256-951C-F8A8ABF284A9@adamw.org> In-Reply-To: <20160722044657.GC37437@FreeBSD.org> References: <201607211847.u6LIluTh087613@repo.freebsd.org> <20160722044657.GC37437@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 21 Jul, 2016, at 22:46, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >=20 > On Thu, Jul 21, 2016 at 06:47:56PM +0000, Kris Moore wrote: >> New Revision: 418889 >> URL: https://svnweb.freebsd.org/changeset/ports/418889 >>=20 >> Log: >> CopyQ is advanced clipboard manager with editing and scripting = features. >>=20 >> WWW: https://github.com/hluk/CopyQ >>=20 >> [...] >> +USE_XORG+=3D x11 xfixes xtst >=20 > What's the reason for +=3D here? >=20 >> +USE_QT5=3D core gui network svg multimedia imageformats \ >=20 > Spaces were used in this line instead of proper tab. >=20 >> +USE_GL+=3D gl >=20 > Bogus +=3D again. >=20 >> +USES=3D qmake >=20 > Spaces again; also it's better to place more generic USES *before* = specific > USE_FOO knobs. >=20 >> +PLIST_FILES=3D bin/copyq >=20 > PLIST-related knobs should be among the last ones (after USE* knobs, = but > before OPTIONS* knobs). AFAIK we've never specified ordering after _DEPENDS. FWIW, Kris's = ordering makes sense to me; the variables are ordered by decreasing = probability of future modification. Though I do agree about all the = +=3D's. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?91496634-0037-4256-951C-F8A8ABF284A9>