Date: Thu, 20 Apr 2017 15:32:29 +0200 From: "Kristof Provost" <kristof@sigsegv.be> To: "Marko Zec" <zec@fer.hr> Cc: freebsd-net@freebsd.org, peter.blok@bsd4all.org Subject: Re: MFC VIMAGE fixes to 11-stable Message-ID: <ACA8734E-88DF-4E7F-BB54-00D393ED7EA6@sigsegv.be> In-Reply-To: <20170420152853.019e5480@x23> References: <8E6FC1CD-24D5-46D5-A6A1-760DD612F92D@bsd4all.org> <20170420124256.1190665d@x23> <60C3FBF7-7CF3-49AF-9DDF-0589AE9D9146@sigsegv.be> <20170420152853.019e5480@x23>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 Apr 2017, at 15:28, Marko Zec wrote: > Right. But pfi_attach_group_event() and the other handlers cited > above > _do_ in fact invoke CURVNET_SET(vnet0) on entry, overriding the proper > vnet choice from the caller. > Yes, that does look wrong. I should have looked a bit further. > Therefore the proper fix should be as simple as removing CURVNET_SET() > / > CURVNET_RESTORE() macro pairs from the cited handlers. > Hopefully, yes. I’ve still got some other pf/vnet issues on my todo list, but I’ve now added this too. It might actually explain some other bug report I’ve seen (but not looked at in any depth). Regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ACA8734E-88DF-4E7F-BB54-00D393ED7EA6>