Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Apr 2018 00:02:22 +0200
From:      Oliver Pinter <oliver.pinter@hardenedbsd.org>
To:        Ram Kishore Vegesna <ram@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Bruce Evans <bde@freebsd.org>
Subject:   Re: svn commit: r332471 - head/sys/dev/ocs_fc
Message-ID:  <CAPQ4ffu09YgGg5cVrQbFF5QYtkH0ASt1xZQtj5j0Y%2B_K1oWaaA@mail.gmail.com>
In-Reply-To: <201804131331.w3DDVKod044086@repo.freebsd.org>
References:  <201804131331.w3DDVKod044086@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, April 13, 2018, Ram Kishore Vegesna <ram@freebsd.org> wrote:

> Author: ram
> Date: Fri Apr 13 13:31:20 2018
> New Revision: 332471
> URL: https://svnweb.freebsd.org/changeset/base/332471
>
> Log:
>   Check if STACK is defined before using the stack(9).
>
>   PR: 227446
>   Reported by: emaste
>   Approved by: ken
>
> Modified:
>   head/sys/dev/ocs_fc/ocs_os.c
>
> Modified: head/sys/dev/ocs_fc/ocs_os.c
> ============================================================
> ==================
> --- head/sys/dev/ocs_fc/ocs_os.c        Fri Apr 13 13:23:31 2018
> (r332470)
> +++ head/sys/dev/ocs_fc/ocs_os.c        Fri Apr 13 13:31:20 2018
> (r332471)
> @@ -37,6 +37,7 @@
>   */
>
>  #include "ocs.h"
> +#include "opt_stack.h"


These types of includes - where you includes opts - should go before any
other includes.



>  #include <sys/sysctl.h>
>  #include <sys/malloc.h>
>  #include <sys/linker.h>                /* for debug of memory allocations
> */
> @@ -855,11 +856,13 @@ void ocs_intr_enable(ocs_os_handle_t os)
>
>  void ocs_print_stack(void)
>  {
> +#if defined(STACK)
>         struct stack st;
>
>         stack_zero(&st);
>         stack_save(&st);
>         stack_print(&st);
> +#endif
>  }
>
>  void ocs_abort(void)
> _______________________________________________
> svn-src-head@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffu09YgGg5cVrQbFF5QYtkH0ASt1xZQtj5j0Y%2B_K1oWaaA>