From owner-freebsd-net@FreeBSD.ORG Mon Aug 31 19:47:34 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28E9B106566C for ; Mon, 31 Aug 2009 19:47:34 +0000 (UTC) (envelope-from stef-list@memberwebs.com) Received: from mail.npubs.com (mail.npubs.com [74.82.45.72]) by mx1.freebsd.org (Postfix) with ESMTP id 1C3D38FC24 for ; Mon, 31 Aug 2009 19:47:33 +0000 (UTC) Resent-Message-Id: From: Stef Walter User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Julian Elischer References: <4A9C137C.7020303@elischer.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Resent-Date: Mon, 31 Aug 2009 19:47:34 +0000 (UTC) Resent-From: stef-list@memberwebs.com Cc: "freebsd-net@FreeBSD.org" Subject: Re: [patch] Unbreak setfib + routing daemons X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: stef@memberwebs.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Mon, 31 Aug 2009 19:47:34 -0000 X-List-Received-Date: Mon, 31 Aug 2009 19:47:34 -0000 Julian Elischer wrote: > there are two ways to go with this one being what you have done teh > other to add fib info to the messages, Apparently > OpenBSD has implemented the second by re-using a disused field. > (I'm ve only been told this second hand) It seems like they've taken apart the rtm_flags field (int), and repurposed it as rtm_tableid (u_short), rtm_priority (u_char) and padding. Obviously such a change would require patches to the various routing daemons as well. But if you think this is the only way forward (ie: filtering the messages in userland), I'd be happy to contribute. > I"ll look a tyour change and see what we can do. > it might just make it to 8.1 at this stage but we can > see what it looks like. I've posted a new patch which should handle all the various senders of route messages better. Qing Li pointed out some naive assumptions I made in my initial patch. It's more complex because we can no longer use M_GETFIB and M_SETFIB to relay FIB information into the netisr routine. > how much have you tested this? I need this for some client systems that we're upgrading. I'll be putting it into production this week. If there's any problems with it, I'll let you and the mailing list know. Cheers, Stef