From owner-svn-src-head@FreeBSD.ORG Mon Oct 26 18:13:59 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3BC3106568F; Mon, 26 Oct 2009 18:13:59 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 74BEE8FC1E; Mon, 26 Oct 2009 18:13:59 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 167BF46B2C; Mon, 26 Oct 2009 14:13:59 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 37ED28A01B; Mon, 26 Oct 2009 14:13:58 -0400 (EDT) From: John Baldwin To: Nathan Whitehorn Date: Mon, 26 Oct 2009 14:13:03 -0400 User-Agent: KMail/1.9.7 References: <200910232253.n9NMr10R074584@svn.freebsd.org> <200910261254.49768.jhb@freebsd.org> <4AE5E043.8070804@freebsd.org> In-Reply-To: <4AE5E043.8070804@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910261413.04317.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 26 Oct 2009 14:13:58 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org Subject: Re: svn commit: r198431 - head/sys/dev/pci X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 18:13:59 -0000 On Monday 26 October 2009 1:45:39 pm Nathan Whitehorn wrote: > John Baldwin wrote: > > On Monday 26 October 2009 12:32:48 pm Marcel Moolenaar wrote: > > > >> On Oct 26, 2009, at 5:37 AM, John Baldwin wrote: > >> > >> > >>>> Log: > >>>> BIOSes, buggy or otherwise, are i386 or amd64 specific. > >>>> Have the early USB takeover enabled for i386 and amd64 > >>>> by default. > >>>> This also avoids a panic on PowerPC where the resource > >>>> isn't released properly and we find a busy resource > >>>> when the USB host controller wants to allocate it... > >>>> > >> > >>> Presumably such systems won't set the 'BIOS owned' bit in the their > >>> legacy > >>> support registers in which case these routines are NOPs (they just > >>> read the > >>> register, see the bit is clear, and exit). The resource bug sounds > >>> like a > >>> real one that should be fixed and would probably affect any x86 > >>> systems who > >>> have USB disabled in the BIOS, so that should be fixed rather than > >>> papered > >>> over. Please revert. > >>> > >> *sigh* > >> > >> The change was made because 1) doing this as part of the PCI code is > >> unnecessary for non-PC HW, and 2) it's entirely untested on non-PC > >> HW and the gratuitous change can therefore only do harm -- he, guess > >> what, it did do harm. > >> > >> Unless people fix the resource stuff this change cannot be reverted. > >> > >> After the resource fix has gone in, I still object to this being > >> reverted on grounds of gratuitous code bloat. I say this with ARM, > >> MIPS and PowerPC/Book-E in mind. > >> > > > > You didn't remove anything, you merely toggled the setting of a variable. > > Code bloat is a non-argument in that case. Could you care to provide details > > on the resource issue you are encountering? I don't see any obvious resource > > leaks, etc. in the current set of changes. > > > > > The real problem in this case is that the > bus_(deactivate|release)_resource methods are not implemented on several > PCI bus drivers on PowerPC (e.g. uninorth, where this problem arose). Up > until now, I guess it has never mattered. Ahh, ok. I'm fine with having it off for those architectures that can't yet handle it with the hope they will be fixed. -- John Baldwin