From owner-cvs-all@FreeBSD.ORG Wed Oct 5 05:24:53 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA45716A41F; Wed, 5 Oct 2005 05:24:53 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98B6243D45; Wed, 5 Oct 2005 05:24:53 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j955OrTY003945; Wed, 5 Oct 2005 05:24:53 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j955OrAq003944; Wed, 5 Oct 2005 05:24:53 GMT (envelope-from truckman) Message-Id: <200510050524.j955OrAq003944@repoman.freebsd.org> From: Don Lewis Date: Wed, 5 Oct 2005 05:24:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2005 05:24:53 -0000 truckman 2005-10-05 05:24:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/ufs/ffs ffs_alloc.c Log: MFC ffs_alloc.c 1.135 - clear i_flag field in recycled inodes Original commit message: FreeBSD src repository Modified files: sys/ufs/ffs ffs_alloc.c Log: Initialize the inode i_flag field in ffs_valloc() to clean up any stale flag bits left over from before the inode was recycled. Without this change, a leftover IN_SPACECOUNTED flag could prevent softdep_freefile() and softdep_releasefile() from incrementing fs_pendinginodes. Because handle_workitem_freefile() unconditionally decrements fs_pendinginodes, a negative value could be reported at file system unmount time with a message like: unmount pending error: blocks 0 files -3 The pending block count in fs_pendingblocks could also be negative for similar reasons. These errors can cause the data returned by statfs() to be slightly incorrect. Some other cleanup code in softdep_releasefile() could also be incorrectly bypassed. Reviewed by: tegge Approved by: re (scottl) Revision Changes Path 1.132.2.1 +1 -0 src/sys/ufs/ffs/ffs_alloc.c