From owner-cvs-all@FreeBSD.ORG Fri Jan 6 17:53:15 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F7F716A41F; Fri, 6 Jan 2006 17:53:15 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFE8443D45; Fri, 6 Jan 2006 17:53:13 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 5441695 for multiple; Fri, 06 Jan 2006 12:54:32 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k06Hr0lF025513; Fri, 6 Jan 2006 12:53:01 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Fri, 6 Jan 2006 12:53:50 -0500 User-Agent: KMail/1.8.2 References: <200601061630.k06GUUXW022868@repoman.freebsd.org> <43BE9C19.6070600@samsco.org> In-Reply-To: <43BE9C19.6070600@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601061253.51551.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1234/Fri Jan 6 08:54:31 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2006 17:53:15 -0000 On Friday 06 January 2006 11:34 am, Scott Long wrote: > John Baldwin wrote: > > jhb 2006-01-06 16:30:30 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_descrip.c > > Log: > > Return EBADF rather than EINVAL for FWRITE failure as per POSIX. > > > > MFC after: 1 week > > > > Revision Changes Path > > 1.290 +2 -3 src/sys/kern/kern_descrip.c > > Technically this will be an API change if it get's MFC'd, though a > minor one. If it needs to go into RELENG_6 then it should be > clearly documented in the release notes. Not really because except for the hwpmc(4) driver and the mqueue code (which isn't in 6.x yet IIRC), every other caller of fget_write() ignores the errno value and hardcodes EBADF, so it won't actually change the errno for any applications in 6.x. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org