Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Mar 2016 14:23:28 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r411712 - in head/sysutils/rename: . files
Message-ID:  <20160323142328.GA64753@FreeBSD.org>
In-Reply-To: <201603231406.u2NE6VQa075069@repo.freebsd.org>
References:  <201603231406.u2NE6VQa075069@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 23, 2016 at 02:06:31PM +0000, Mathieu Arnold wrote:
> New Revision: 411712
> URL: https://svnweb.freebsd.org/changeset/ports/411712
> 
> Log:
>   Update to 1.99.2.
>   
>   PR:		208212
>   Submitted by:	tkato432 yahoo com
> 
> Deleted:
>   head/sysutils/rename/files/

OK, so nice and readable `files/patch-Makefile.in' was deleted...

> +post-patch:
> +	@${REINPLACE_CMD} -e \
> +		'/^CC/s|\([[:blank:]]\)\(=\)|\1?\2| ; \
> +		 /^PREFIX/s|\([[:blank:]]\)\(=\)|\1?\2| ; \
> +		 s|/usr/local/bin|$$(PREFIX)/bin| ; \
> +		 s|/usr/local/man|$$(PREFIX)/man| ; \
> +		 /^CFLAGS/s|\([[:blank:]]\)\(=\)|\1+\2| ; \
> +		 s|-O[0-9]|| ; \
> +		 s|$$^$$|$$(OBJS)| ; \
> +		 /cp/s|^|#| ; \
> +		 s|install .* 0755 -s|$${BSD_INSTALL_PROGRAM}| ; \
> +		 s|\([[:blank:]]\)\($$(BINDIR)\)|\1$$(DESTDIR)\2| ; \
> +		 s|install .* 0644|$${BSD_INSTALL_MAN}| ; \
> +		 s|\([[:blank:]]\)\($$(MANDIR)\)|\1$$(DESTDIR)\2| ; \
> +		 s|^%.*|.c.o:|' \
> +		${WRKSRC}/Makefile

...and replaced with this unholy mess instead?  In-place editing could be
justified if expanded values were used, but those $$'s indicate a normal
patch would suffice.

> Modified: head/sysutils/rename/pkg-descr
> ...
> @@ -1,7 +1,8 @@
> -Rename is a quick and powerful tool written in C, featuring extended regular
> -expression support for searching and substituting pattern strings in filenames.
> +Rename is a quick and powerful tool written in C, featuring extended
> +regular expression support for searching and substituting pattern
> +strings in filenames.
>  
> -Rename can rename, convert to lowercase/uppercase, and change the ownership of
> -a large number of files.
> +Rename can rename, convert to lowercase/uppercase, and change the
> +ownership of a large number of files.

There was nothing wrong with previous version, and it has nothing to do
with "update to 1.99.2" anyways, please reinstate it.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160323142328.GA64753>